-
Notifications
You must be signed in to change notification settings - Fork 39
Jackson 3 port #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Jackson 3 port #73
Conversation
678c2a2 to
b42b776
Compare
|
I skimmed through this and it generally looks fine to me for now. A few considerations below before this gets merged, but nothing specific to your work. It just means this will probably sit for a while before being merged in.
|
|
I agree, this looks good.
|
|
I have no problem keeping this open and updating it whenever master changes. It would probably make sense to do the Java 17 and javax changes in this PR, but we'll see :) |
b42b776 to
05a95db
Compare
|
Hi ! |
|
I believe this is blocked by paul-hammant/qdox#292. |
|
I think that #101 will cause that qdox issue to not happen. However, that’s only temporary because we do want to undo some of the changes from that PR when going to Jackson. 3 which would reintroduce the qdox issue. We can make some progress towards Jackson 3 in the meantime. This PR is still going to be blocked on a few other things first though, but nothing that we can’t resolve ourselves. So, Jackson 3 support is a work in progress right now without a known timeline. |
Jackson 3 is not out yet, but decided to try porting it to latest RC. I'm not super experienced with Jackson, but luckily this repo has plenty of tests. Let me know if this helps 😄