-
Notifications
You must be signed in to change notification settings - Fork 62
ci: create release PR #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db0c30c to
f8f965b
Compare
a1d62b8 to
397c9a5
Compare
58fca6c to
e0b6002
Compare
| with: | ||
| ref: ${{ needs.prep.outputs.release_branch }} | ||
|
|
||
| - name: Configure Git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why isnt this in the update-version job i.e. do these steps before create-release pr job?
| echo "$cleaned_notes" >> $GITHUB_ENV | ||
| echo "EOF" >> $GITHUB_ENV | ||
|
|
||
| - name: Draft Release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesnt seem needed to create a draft release?
I also have shared github release. Example usage:
https://github.com/OneSignal/OneSignal-Cordova-SDK/blob/main/.github/workflows/cd.yml
https://github.com/OneSignal/sdk-actions/blob/main/.github/workflows/github-release.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe a separate pr action to run after pr is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I made them together is that I need to copy release notes generated by the shared action to the CHANGELOG inside the Unity project and commit it before release, which is conflicting because the shared action is for after release. I just moved the release part to a separate workflow.
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't look at it closely
Description
One Line Summary
Create a workflow to automate the Unity release process.
Testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is