Skip to content

Refactor version switcher styles #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor version switcher styles #227

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e7dfd
Refactor version switcher styles
palpavasiya Nov 6, 2025
068a291
Add focus styles to version switcher component
palpavasiya Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/livewire/version-switcher.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
class="
inline-flex items-center
opacity-60 hover:opacity-100 transition-opacity duration-200
focus-within:outline-2 focus-within:rounded-xs focus-within:outline-offset-2
Copy link
Contributor

@gwleuverink gwleuverink Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this focus state without providing an alternative? This is used when using keyboard navigation on the site. e.g. tab & space

Copy link
Author

@palpavasiya palpavasiya Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Unfortunately, I haven't found an alternative method for that issue. The previous code is better for handling keyboard navigation and provides a better user experience, so let's stick with that one.

"
>

Expand All @@ -14,9 +13,10 @@ class="
wire:model.live="version"
class="
-ml-1 py-0 pr-8
bg-transparent border-0
border-0
text-sm whitespace-nowrap
focus:ring-0
dark:bg-black
"
>

Expand Down