Switch to go 1.25 os.Root #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
use-os-root
branch
2 times, most recently
from
7754866 to
599ab62
Compare
Member
Author
|
/cherry-pick release-1.18 |
ArangoGutierrez
approved these changes
Nov 12, 2025
Collaborator
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
LGTM
os.Root is a new type that allows you to perform file operations, such as opening files, within a specific directory. This enhances security by restricting filesystem access to only that directory.
This was referenced Nov 12, 2025
elezar
force-pushed
the
use-os-root
branch
2 times, most recently
from
b2574e3 to
3045bd7
Compare
ArangoGutierrez
approved these changes
Nov 12, 2025
Collaborator
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Re-approve after new changes
ArangoGutierrez
approved these changes
Nov 12, 2025
Collaborator
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Commit was updated
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
🤖 Backport PR created for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches to using standard library functions for creating files in specified root folders. This removes the direct dependency on
github.com/cyphar/filepath-securejoinand simplifies how libcontainer utilites are consumed.This should unblock (or make redundant) the following PRs: