[TRTLLM-9018][infra] Use source code mirror for CI Build Docker Images stage. #9129
Conversation
|
/bot run --stage-list "Build-Docker-Images" |
📝 WalkthroughWalkthroughDocker installation scripts are being refactored to download source code via tarballs instead of git clones, with centralized GitHub URL configuration supporting mirror overrides. The Dockerfile is updated to propagate the mirror variable to the mooncake installation step. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker/common/install_nixl.sh (1)
50-50: Add Meson prefix flag to match hardcoded LD_LIBRARY_PATH.Meson's default prefix is
/usr/localon Unix systems, but line 51 exportsLD_LIBRARY_PATHpointing to/opt/nvidia/nvda_nixl/lib/.... This mismatch will cause runtime failures—libraries installed to/usr/localwon't be found.Add
-Dprefix=/opt/nvidia/nvda_nixlto the meson setup command (lines 39–44):meson setup builddir \ -Dprefix=/opt/nvidia/nvda_nixl \ -Ducx_path=$UCX_INSTALL_PATH \ ...
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docker/Dockerfile.multi(1 hunks)docker/common/install_mooncake.sh(3 hunks)docker/common/install_nixl.sh(2 hunks)docker/common/install_ucx.sh(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-20T15:04:42.885Z
Learnt from: dbari
Repo: NVIDIA/TensorRT-LLM PR: 7095
File: docker/Dockerfile.multi:168-168
Timestamp: 2025-08-20T15:04:42.885Z
Learning: In docker/Dockerfile.multi, wildcard COPY for benchmarks (${CPP_BUILD_DIR}/benchmarks/*Benchmark) is intentionally used instead of directory copy because the benchmarks directory contains various other build artifacts during C++ builds, and only specific benchmark executables should be copied to the final image.
Applied to files:
docker/Dockerfile.multi
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (5)
docker/common/install_ucx.sh (2)
4-7: Good: Consistent GITHUB_URL pattern with mirror override.The centralized
GITHUB_URLvariable with conditionalGITHUB_MIRRORoverride allows seamless fallback to public GitHub when no mirror is configured. This pattern is replicated consistently across all installation scripts.
14-16: Verify tarball extraction preserves expected directory structure.The tarball download and extraction flow assumes GitHub's archive endpoint produces
ucx-v1.19.x/as the top-level directory. Confirm this matches the actual archive structure; if not, themvcommand will fail.docker/Dockerfile.multi (1)
111-111: Good: GITHUB_MIRROR correctly propagated to install_mooncake.sh.The environment variable is properly passed and follows the established pattern (lines 82, 85). However, the success of this stage depends on resolving the git submodule issue in
install_mooncake.sh(line 50), which will cause this Docker build to fail.docker/common/install_nixl.sh (2)
5-7: Good: Consistent GITHUB_URL override pattern.Follows the same centralized mirror approach as other installation scripts. The conditional check guards against undefined
GITHUB_MIRROR.
30-35: Good: Defensive CUDA library validation.The explicit check for
libcuda.so.1with early exit (status 1) prevents silent build failures downstream. This is a solid improvement over relying on implicit CUDA availability.
|
PR_Github #24423 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #24427 [ run ] triggered by Bot. Commit: |
|
PR_Github #24423 [ run ] completed with state |
|
PR_Github #24427 [ run ] completed with state |
Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
ZhanruiSunCh
force-pushed
the
user/zhanruis/1113_jira_9018
branch
from
65336b0 to
44f3c44
Compare
|
/bot run --stage-list "Build-Docker-Images" |
ZhanruiSunCh
requested review from
EmmaQiaoCh,
chzblych,
niukuo and
yiqingy0
|
PR_Github #25020 [ run ] triggered by Bot. Commit: |
ZhanruiSunCh
force-pushed
the
user/zhanruis/1113_jira_9018
branch
from
44f3c44 to
17f3e0a
Compare
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #25034 [ run ] triggered by Bot. Commit: |
|
PR_Github #25020 [ run ] completed with state |
|
PR_Github #25034 [ run ] completed with state |
2 participants
Summary by CodeRabbit
New Features
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.