Skip to content

Conversation

@lucaslie
Copy link
Member

@lucaslie lucaslie commented Nov 11, 2025

@coderabbitai summary

Description

  • I have added the correct sharding config to be consistent with the rest but even without the extra sharding config I get correct accuracy results for TP=8.
  • I have also removed the warning from the HF logger that gets triggered when loading sharded MoE weights where some weights are missing which spams the entire logging output and makes it really hard to debug MoE issues from prints

accuracy results

accuracy test as is in PR

TP=1, MMLU: 79.020
TP=1, gsm8k: 82.828

TP=4, MMLU: 79.118
TP=4, gsm8k: 83.965

TP=8, MMLU: 79.142
TP=8, gsm8k: 83.851

accuracy test without updated sharding config

TP=8, MMLU: 79.142
TP=8, gsm8k: 84.041

accuracy test with fp32 cache activated

TP=1, fp32 cache, MMLU: 79.264 
TP=1, fp32 cache, gsm8k: **logs missing**

TP=4, fp32 cache, MMLU: 79.142
TP=4, fp32 cache, gsm8k: 84.041

TP=8, fp32 cache, MMLU: 78.972
TP=8, fp32 cache, gsm8k: 83.055

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie lucaslie requested a review from a team as a code owner November 11, 2025 05:46
@lucaslie lucaslie requested a review from MrGeva November 11, 2025 05:46
@lucaslie lucaslie requested review from nvchenghaoz and suyoggupta and removed request for MrGeva November 11, 2025 05:46
@lucaslie lucaslie self-assigned this Nov 11, 2025
@lucaslie lucaslie moved this from Backlog to In review in AutoDeploy Board Nov 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

📝 Walkthrough

Walkthrough

Changes add enhanced logging control to the HF model state_dict loading patch by switching logger level to ERROR to suppress warnings, and introduce detect_sharding configuration with sharding_source and sharding_dims parameters to test deployment setup.

Changes

Cohort / File(s) Change Summary
HF Model Loading
tensorrt_llm/_torch/auto_deploy/models/hf.py
Enhanced hf_load_state_dict_with_device patch documentation to include logger level switching to ERROR during patching; saves and restores original logger level to suppress HF state_dict warnings. Internal behavior refinement with no public API changes.
Test Configuration
tests/integration/defs/accuracy/test_llm_api_autodeploy.py
Added transforms block to TestNemotronMOE.get_default_kwargs() with detect_sharding configuration specifying sharding_source and sharding_dims parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Logging control addition is straightforward state management (save/restore pattern)
  • Configuration addition to test is a simple dictionary extension with new parameters
  • Changes follow predictable patterns with minimal functional complexity

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive PR description partially addresses requirements but lacks clarity on key sections and missing critical information needed for proper review. Add a proper PR title following the template format, provide a concise explanation of the issue and solution, and list specific test cases that validate the changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the nano3 accuracy test in AutoDeploy. It follows the required format with [None][fix] prefix and concisely communicates the primary purpose of the PR.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24120 [ run ] triggered by Bot. Commit: 89be9cb

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24120 [ run ] completed with state FAILURE. Commit: 89be9cb
/LLM/main/L0_MergeRequest_PR pipeline #18181 completed with status: 'FAILURE'

Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24144 [ run ] triggered by Bot. Commit: a24754a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24144 [ run ] completed with state SUCCESS. Commit: a24754a
/LLM/main/L0_MergeRequest_PR pipeline #18204 completed with status: 'SUCCESS'

@lucaslie lucaslie merged commit aca5609 into NVIDIA:main Nov 11, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Nov 11, 2025
@lucaslie lucaslie deleted the ll/debug_tp8_nano3 branch November 11, 2025 20:26
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 12, 2025
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants