Skip to content

Conversation

@chang-l
Copy link
Collaborator

@chang-l chang-l commented Nov 10, 2025

Normally, activations are not in float32; as a result, LayerNorm ends up issuing three kernels (2 cp + 1 layernorm op).
This PR leverages torch.compile to fuse these operations into a single kernel, removing the redundant memory traffic and launch overhead.

Dependency PR: #8988

Before this PR:
Screenshot 2025-11-10 at 3 06 53 PM

===========================================================
= PERFORMANCE OVERVIEW
===========================================================
Request Throughput (req/sec):                     1.3717
Total Output Throughput (tokens/sec):             2809.1876
Total Token Throughput (tokens/sec):              4239.6074
Total Latency (ms):                               46658.3300
Average request latency (ms):                     46612.0998
Per User Output Throughput [w/ ctx] (tps/user):   43.9371
Per GPU Output Throughput (tps/gpu):              351.148

With this PR (~1.02x speedup):
image

===========================================================
= PERFORMANCE OVERVIEW
===========================================================
Request Throughput (req/sec):                     1.4004
Total Output Throughput (tokens/sec):             2867.9297
Total Token Throughput (tokens/sec):              4328.2607
Total Latency (ms):                               45702.6540
Average request latency (ms):                     45658.2250
Per User Output Throughput [w/ ctx] (tps/user):   44.8550
Per GPU Output Throughput (tps/gpu):              358.4912

Summary by CodeRabbit

  • Refactor
    • Enhanced layer normalization operations with dynamic compilation optimization to improve performance.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chang-l chang-l requested a review from a team as a code owner November 10, 2025 22:54
@chang-l chang-l requested a review from mikeiovine November 10, 2025 22:54
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

📝 Walkthrough

Walkthrough

A decorator (@maybe_compile(dynamic=True)) was added to the forward method of the LayerNorm class to enable dynamic compilation. The import for maybe_compile was added from the utils module. No changes to method signature or core logic.

Changes

Cohort / File(s) Change Summary
Dynamic compilation for LayerNorm
tensorrt_llm/_torch/modules/layer_norm.py
Added import of maybe_compile utility and applied @maybe_compile(dynamic=True) decorator to the forward method to introduce dynamic compilation capability.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify that maybe_compile utility is correctly imported and available from the specified path
  • Confirm that applying dynamic=True to LayerNorm's forward method is the intended behavior and does not introduce unexpected performance or compatibility implications
  • Ensure the decorator placement does not inadvertently affect method resolution or override chain behavior

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The PR description contains performance metrics and background context, but critical template sections (Description, Test Coverage) are not filled in with substantive content. Fill in the Description section with a clear explanation of the issue and solution, and the Test Coverage section with specific test cases that validate the changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: using torch.compile with dynamic compilation to optimize LayerNorm by fusing copy and layernorm operations.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chang-l chang-l requested review from Funatiq and lfr-0531 November 10, 2025 23:50
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
@chang-l
Copy link
Collaborator Author

chang-l commented Nov 11, 2025

/bot run

Copy link
Collaborator

@lfr-0531 lfr-0531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24107 [ run ] triggered by Bot. Commit: debe9f2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24107 [ run ] completed with state SUCCESS. Commit: debe9f2
/LLM/main/L0_MergeRequest_PR pipeline #18169 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@chang-l chang-l merged commit 0b81173 into NVIDIA:main Nov 12, 2025
5 checks passed
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 12, 2025
… the LayerNorm module (NVIDIA#9052)

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants