debug b200 #9040
debug b200 #9040
Conversation
|
/bot run --stage-list="DGX_B200-4_GPUs-PyTorch-Post-Merge-1" |
📝 WalkthroughWalkthroughGPU resource allocations are updated from 4 to 10 across Groovy and YAML test configurations. However, a YAML syntax error is introduced that will break parsing in the integration test database file. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/test_lists/test-db/l0_dgx_b200.yml (1)
63-86: CRITICAL: YAML syntax error — malformed key at line 86.Line 86 contains
- ondition:instead of- condition:. This typo introduces a top-level YAML key error that will break parsing of the test database file and cause test rendering to fail.Apply this fix:
- ondition: + condition:This fix is blocking and must be applied before merge. The malformed key will break the entire test-db file parsing.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(1 hunks)tests/integration/test_lists/test-db/l0_dgx_b200.yml(3 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: venkywonka
Repo: NVIDIA/TensorRT-LLM PR: 6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
jenkins/L0_Test.groovytests/integration/test_lists/test-db/l0_dgx_b200.yml
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Applied to files:
tests/integration/test_lists/test-db/l0_dgx_b200.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/test-db/l0_dgx_b200.yml (1)
3-62: Approved: GPU allocation updated from 4 to 10 GPUs for pre_merge pytorch/mpi tests.The system_gpu_count range update (lines 6-7) is syntactically correct. Verify that the downstream Groovy configuration and actual test hardware can support 10 GPU allocations for this workload.
jenkins/L0_Test.groovy
Outdated
| "DGX_B200-4_GPUs-PyTorch-Ray-1": ["b200-x4", "l0_dgx_b200", 1, 1, 4], | ||
| "DGX_B200-8_GPUs-PyTorch-1": ["b200-x8", "l0_dgx_b200", 1, 1, 8], | ||
| "DGX_B200-4_GPUs-PyTorch-Post-Merge-1": ["b200-trtllm", "l0_dgx_b200", 1, 1, 4, 1, true], | ||
| "DGX_B200-4_GPUs-PyTorch-Post-Merge-1": ["b200-trtllm", "l0_dgx_b200", 1, 1, 10, 1, true], |
There was a problem hiding this comment.
🧩 Analysis chain
GPU count updated to 10, but stage name still indicates 4 GPUs — naming inconsistency.
The GPU count in the configuration array (5th element) has been increased from 4 to 10, but the stage name still reads "DGX_B200-4_GPUs-PyTorch-Post-Merge-1". This mismatch will cause confusion in CI logs, test reports, and dashboards.
Consider updating the stage name to "DGX_B200-10_GPUs-PyTorch-Post-Merge-1" to align with the actual GPU allocation. Per the requirements documented at lines 2549–2566, this stage name is part of the test_to_stage_mapping.py contract, so any change may impact downstream tooling.
Also note: This configuration depends on successful parsing of the l0_dgx_b200.yml file, which currently contains a YAML syntax error (see critical issue in l0_dgx_b200.yml line 86).
🏁 Script executed:
#!/bin/bash
# Check line 2688 in jenkins/L0_Test.groovy and surrounding context
echo "=== Line 2688 context from jenkins/L0_Test.groovy ==="
if [ -f "jenkins/L0_Test.groovy" ]; then
sed -n '2685,2691p' jenkins/L0_Test.groovy
else
echo "File not found"
fi
echo ""
echo "=== Searching for DGX_B200 stage configurations ==="
rg -n "DGX_B200.*GPUs" jenkins/L0_Test.groovy | head -20
echo ""
echo "=== Checking if l0_dgx_b200.yml exists ==="
find . -name "l0_dgx_b200.yml" -o -name "l0_dgx_b200*" 2>/dev/null | head -10Length of output: 1301
🏁 Script executed:
#!/bin/bash
# Check test_to_stage_mapping.py for stage name contract
echo "=== Looking for test_to_stage_mapping.py ==="
find . -name "test_to_stage_mapping.py" 2>/dev/null
echo ""
echo "=== Searching for test_to_stage_mapping references ==="
rg -n "test_to_stage_mapping" jenkins/L0_Test.groovy | head -5
echo ""
echo "=== Check for any YAML files related to dgx_b200 ==="
find . -type f \( -name "*.yml" -o -name "*.yaml" \) | xargs grep -l "b200\|dgx_b200" 2>/dev/null | head -10Length of output: 734
🏁 Script executed:
#!/bin/bash
# Check git history to confirm GPU count change
echo "=== Git log for line 2688 area ==="
if git log --oneline -p -S "DGX_B200-4_GPUs" -- jenkins/L0_Test.groovy 2>/dev/null | head -50; then
echo "Found history"
else
echo "No git history or search term not found"
fi
echo ""
echo "=== Recent changes to jenkins/L0_Test.groovy ==="
git log --oneline -5 -- jenkins/L0_Test.groovy 2>/dev/null || echo "Git not available"Length of output: 3038
🏁 Script executed:
#!/bin/bash
# Check l0_dgx_b200.yml for syntax errors, especially around line 86
echo "=== Lines 80-92 from l0_dgx_b200.yml ==="
if [ -f "./tests/integration/test_lists/test-db/l0_dgx_b200.yml" ]; then
sed -n '80,92p' "./tests/integration/test_lists/test-db/l0_dgx_b200.yml"
else
echo "File not found"
fi
echo ""
echo "=== Full l0_dgx_b200.yml for syntax validation ==="
cat "./tests/integration/test_lists/test-db/l0_dgx_b200.yml" | head -100Length of output: 8142
🏁 Script executed:
#!/bin/bash
# Check the array element interpretation in jenkins/L0_Test.groovy
echo "=== Understanding the configuration array structure ==="
echo "Looking at comments or documentation near the configuration..."
rg -B5 -A2 "platform, yaml_file" jenkins/L0_Test.groovy | head -20
echo ""
echo "=== Check how the array elements are parsed ==="
rg -n "taskConfig\[" jenkins/L0_Test.groovy | head -10Length of output: 167
🏁 Script executed:
#!/bin/bash
# Verify the YAML syntax error more precisely
echo "=== Line 90-95 of l0_dgx_b200.yml (exact content) ==="
if [ -f "./tests/integration/test_lists/test-db/l0_dgx_b200.yml" ]; then
sed -n '90,95p' "./tests/integration/test_lists/test-db/l0_dgx_b200.yml"
else
echo "File not found"
fi
echo ""
echo "=== Check for Python YAML parsing of the file ==="
python3 << 'EOF'
import yaml
try:
with open('./tests/integration/test_lists/test-db/l0_dgx_b200.yml', 'r') as f:
data = yaml.safe_load(f)
print("✓ YAML parsing successful")
print(f"Top-level keys: {list(data.keys()) if isinstance(data, dict) else 'Not a dict'}")
except yaml.YAMLError as e:
print(f"✗ YAML parsing error: {e}")
except Exception as e:
print(f"✗ Error: {e}")
EOFLength of output: 288
🏁 Script executed:
#!/bin/bash
# Check how stage names with GPU counts are used elsewhere
echo "=== Other DGX_B200 stage names and their GPU allocations ==="
rg -A0 "DGX_B200.*GPUs.*PyTorch" jenkins/L0_Test.groovy | grep -E '".*":'
echo ""
echo "=== Pattern check: do all stage names match their GPU counts? ==="
echo "Checking if naming is consistent across all similar stages..."
rg '"DGX_B200-.*-GPUs' jenkins/L0_Test.groovy | cut -d':' -f2Length of output: 700
GPU count and stage name mismatch: update stage name to reflect 10 GPU allocation.
The stage configuration at line 2688 allocates 10 GPUs (5th array element) but the stage name reads "DGX_B200-4_GPUs-PyTorch-Post-Merge-1". This inconsistency conflicts with the naming pattern used across all other DGX_B200 stages (e.g., "DGX_B200-8_GPUs-PyTorch-1" with 8 GPUs).
Update the stage name to "DGX_B200-10_GPUs-PyTorch-Post-Merge-1" to match the GPU allocation and maintain clarity in CI logs and test reports.
🤖 Prompt for AI Agents
In jenkins/L0_Test.groovy around line 2688, the stage name
"DGX_B200-4_GPUs-PyTorch-Post-Merge-1" does not match the configured GPU count
(10 at the 5th array element); update the stage name to
"DGX_B200-10_GPUs-PyTorch-Post-Merge-1" so it reflects the allocated 10 GPUs and
follows the naming pattern used for other DGX_B200 stages.
|
PR_Github #23997 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list="DGX_B200-10_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #23997 [ run ] completed with state |
|
PR_Github #24008 [ run ] triggered by Bot. Commit: |
|
PR_Github #24008 [ run ] completed with state |
yuanjingx87
force-pushed
the
user/yuanjingx/debug_b200
branch
from
7d87984 to
f77a6be
Compare
|
/bot run --stage-list="DGX_B200-10_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #24035 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list="DGX_B200-10_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #24037 [ run ] triggered by Bot. Commit: |
|
PR_Github #24035 [ run ] completed with state |
|
PR_Github #24037 [ run ] completed with state |
yuanjingx87
force-pushed
the
user/yuanjingx/debug_b200
branch
from
f77a6be to
0c9556a
Compare
|
/bot run --stage-list="DGX_B200-10_GPUs-PyTorch-Post-Merge-1" |
yuanjingx87
force-pushed
the
user/yuanjingx/debug_b200
branch
from
0c9556a to
d3cf7cd
Compare
|
/bot run --stage-list="DGX_B200-10_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #24259 [ run ] triggered by Bot. Commit: |
|
PR_Github #24259 [ run ] completed with state |
|
/bot run --stage-list="DGX_B200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #24282 [ run ] triggered by Bot. Commit: |
|
PR_Github #24282 [ run ] completed with state |
|
/bot run --stage-list="DGX_B200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #24345 [ run ] triggered by Bot. Commit: |
|
PR_Github #24345 [ run ] completed with state |
yuanjingx87
force-pushed
the
user/yuanjingx/debug_b200
branch
from
d3cf7cd to
a431dc4
Compare
|
/bot run --stage-list="DGX_B200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #24450 [ run ] triggered by Bot. Commit: |
|
PR_Github #24450 [ run ] completed with state |
|
/bot run --stage-list="DGX_B200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #24511 [ run ] triggered by Bot. Commit: |
|
PR_Github #24511 [ run ] completed with state |
2 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.