Add AsyncWriter #27
Open
Add AsyncWriter #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the OffthreadFileWriter implementation with a writer that manages its own message queue and thread. Note: could use an audit and simplification by someone who knows the Java memory model regarding threading.
src/main/java/net/modfest/fireblanket/util/OffthreadFileWriter.java
Outdated
Show resolved
Hide resolved
Awakened-Redstone
requested changes
Aug 23, 2025
src/main/java/net/modfest/fireblanket/util/OffthreadFileWriter.java
Outdated
Show resolved
Hide resolved
Awakened-Redstone
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the OffthreadFileWriter implementation with a writer that manages its own message queue and thread.
Note: could use an audit and simplification by someone who knows the Java memory model regarding threading. I aimed to handle edgecases generically to allow it to be shoved into anything; but it hasn't seen a proper optimization pass.