Skip to content

Conversation

@exchange12rocks
Copy link
Contributor

PR Summary

For a long time the documentation haven't explained clearly the relationship between the Group and DisplayGroup properties of Windows Firewall rules and the corresponding cmdlet parameters. With this PR I hope to bring more clarity into explanation of those terms.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@github-actions
Copy link

STOP Caution: Large pull request

This public repo applies limits on the number of files that can be merged in a single pull request (PR):

  • Warning Warning message and ability to unblock PR using the Merge large pull request* label - 30
  • Block Block message and PR is blocked - 100

This pull request will change 32 files, which exceeds the warning limit of 30.

Before this pull request can be merged, you must review the list of files it contains and their changes to confirm they are correct and intentional. This includes files you did not change and/or do not own. If there are changes you aren't familiar with, contact the individuals who submitted the commits included in this pull request and review the changes with them.

The individual who merges this pull request is responsible for ensuring the changes included in it are correct, and for resolving any issues that might result in merging it.

To merge this pull request

If you have determined that the changes in this pull request are correct, add the Merge large pull request* label to it, wait for the max/pr-file-count check to pass, and then click Merge. To add a label, click the gear icon next to Labels and then select Merge large pull request*.

Label UI screenshot

To reject this pull request

If you can't confirm the changes in this pull request are correct, click Close pull request at the bottom of this page to close it without merging. Work with your team to revert any changes that aren't correct.

* You must have write or triage access to this repo to add labels.

@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 725e028:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/NetSecurity/Copy-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/NetSecurity/Disable-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/NetSecurity/Enable-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/NetSecurity/Get-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/NetSecurity/New-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/NetSecurity/Remove-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/NetSecurity/Rename-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/NetSecurity/Set-NetFirewallRule.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/NetSecurity/Copy-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/NetSecurity/Disable-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/NetSecurity/Enable-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/NetSecurity/Get-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/NetSecurity/New-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/NetSecurity/Remove-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/NetSecurity/Rename-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/NetSecurity/Set-NetFirewallRule.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/NetSecurity/Copy-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/NetSecurity/Disable-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/NetSecurity/Enable-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/NetSecurity/Get-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/NetSecurity/New-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/NetSecurity/Remove-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/NetSecurity/Rename-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/NetSecurity/Set-NetFirewallRule.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2025-ps/NetSecurity/Copy-NetFirewallRule.md ✅Succeeded View (WindowsServer2025-ps)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant