-
Notifications
You must be signed in to change notification settings - Fork 188
Make the TripPin.Feed type change more clear
#522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 8eccc7d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
|
@JasonWHowell @ptyx507x - Is this proposed update still slated for engineering review? |
|
@ktoliver I'm not on this team any longer. @DougKlopfenstein is the writer on Kate's team. |
OK, thanks @JasonWHowell |
I missed the step of updating the
connectorcode to change the schema parameter and it took a while to figure out why all my unit tests were coming back asnullexcept for theCheck that we have three entries in our nav tabletest. It might be better to explicitly show this step. LMKWYT