Update to ethereumjs-util@6 #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
ethereumjs-util-6
branch
from
809f84d to
86abead
Compare
Codecov Report
@@ Coverage Diff @@
## develop #142 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1430 1432 +2
Branches 192 192
======================================
+ Hits 1430 1432 +2
Continue to review full report at Codecov.
|
bitpshr
approved these changes
Aug 13, 2019
bitpshr
pushed a commit
that referenced
this pull request
Aug 20, 2019
* Update direct dep to ethereumjs-util@6 * Update ethereumjs-util imports where possible
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Update direct dep to ethereumjs-util@6 * Update ethereumjs-util imports where possible
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Update direct dep to ethereumjs-util@6 * Update ethereumjs-util imports where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the direct
ethereumjs-utildependency to v6, which includes TypeScript definitions. There are no relevant breaking changes to GABA's direct usage:[1]I've changed the places where
ethereumjs-utilare beingrequire'd to use TypeScript imports where possible (minusBNwhose types don't match the usages and #141).