Skip to content

Fix decimal parsing for non-dot decimal point #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix decimal parsing for non-dot decimal point #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions YahooFinance.Core/YahooFinance.Core/Core/Converters/DecimalCsvConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,23 @@
using CsvHelper.Configuration;
using CsvHelper.TypeConversion;
using System;
using System.Globalization;

namespace MatthiWare.YahooFinance.Core.Converters
{
/// <inheritdoc/>
public class DecimalCsvConverter : DefaultTypeConverter
{
/// <inheritdoc/>
public override object ConvertFromString(string text, IReaderRow row, MemberMapData memberMapData)
public override object ConvertFromString(
string text,
IReaderRow row,
MemberMapData memberMapData
)
{
if (!decimal.TryParse(text, out var convertedDecimal))
{
return decimal.MinValue;
}

return convertedDecimal;
return decimal.TryParse(text, NumberStyles.Any, CultureInfo.InvariantCulture, out var convertedDecimal)
? convertedDecimal
: decimal.MinValue;
}
}
}
}