-
-
Notifications
You must be signed in to change notification settings - Fork 61
Plot compile to lambdify compile #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
One minor comment on the import in plot3d_vectorized.py which I will add, otherwise lgtm. |
| import numpy as np | ||
|
|
||
| from mathics.builtin.colors.color_internals import convert_color | ||
| from mathics.core.convert.lambdify import lambdify_compile as plot_compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor point - I think it would be better to import as lambdify_compile, and change the one use of it in this file, to get rid of the name plot_compile altogether.
@bdlucas1, this is a proposal about where I think the lambdify code should be located. If this is not too disruptive, the next thing would be to use this code in the different places where we need compiled versions of WL expressions, like in table generations, numerical integration, and optimizers.