Skip to content

Conversation

@mmatera
Copy link
Contributor

@mmatera mmatera commented Nov 30, 2025

@bdlucas1, this is a proposal about where I think the lambdify code should be located. If this is not too disruptive, the next thing would be to use this code in the different places where we need compiled versions of WL expressions, like in table generations, numerical integration, and optimizers.

@bdlucas1
Copy link
Collaborator

bdlucas1 commented Dec 1, 2025

If this is not too disruptive,
From that perspective I'm fine with this, if you think it's mature enough to be useful.

use this code in the different places where we need compiled versions of WL expressions
I have no comment on this because I'm not familiar with those uses, other than to say I'm not sure how complete function coverage is for lambdify_compile - not really sure how exhaustive the list of tests is, and of those a lot fail, although those mostly tend to be obscure numerical functions.

One minor comment on the import in plot3d_vectorized.py which I will add, otherwise lgtm.

import numpy as np

from mathics.builtin.colors.color_internals import convert_color
from mathics.core.convert.lambdify import lambdify_compile as plot_compile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor point - I think it would be better to import as lambdify_compile, and change the one use of it in this file, to get rid of the name plot_compile altogether.

@mmatera mmatera marked this pull request as ready for review December 1, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants