Skip to content

Conversation

@Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Nov 7, 2025

WHAT

  • Added a concise explanation of the ROUNDUP(MAX(3, 2N/3)) consensus threshold plus the helper snippet to the staking/delegation doc.
  • Brought the full signing scheme + curve matrix (with chain context) into the How It Works page so conceptual readers see the supported cryptography without jumping to the SDK guide.

Copilot AI review requested due to automatic review settings November 7, 2025 15:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation by adding technical details about consensus requirements and supported cryptographic schemes, while also cleaning up formatting.

  • Adds a new "Consensus Threshold Rule" section explaining the threshold requirements for Lit validator and signing operations
  • Introduces a comprehensive table of supported cryptographic signing schemes and curves
  • Removes trailing whitespace at the end of documentation files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/node-ops/staking-and-delegation.mdx Adds consensus threshold rule documentation and removes trailing blank lines
docs/learning-lit/how-it-works.mdx Adds detailed table of supported cryptographic schemes/curves with SDK reference link and removes trailing blank line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


## Consensus Threshold Rule

All Lit validator and signing operations are guarded by a threshold rule that requires at least `ROUNDUP(MAX(3, 2N/3))` participating nodes for a committee of size `N`.
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mathematical formula 2N/3 is ambiguous and could be misinterpreted. Consider writing it as 2*N/3 or (2N)/3 to make it clear that N should be multiplied by 2 before dividing by 3. Alternatively, you could express it in clearer prose, such as "two-thirds of N".

Suggested change
All Lit validator and signing operations are guarded by a threshold rule that requires at least `ROUNDUP(MAX(3, 2N/3))` participating nodes for a committee of size `N`.
All Lit validator and signing operations are guarded by a threshold rule that requires at least `ROUNDUP(MAX(3, 2*N/3))` participating nodes for a committee of size `N`.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants