-
Notifications
You must be signed in to change notification settings - Fork 88
fix(artillery): align init helpers, state cache, and docs #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: naga
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates import paths for Artillery utilities and adds BigInt serialization support to the state manager, along with comprehensive documentation for Artillery load testing.
- Simplified imports from
@lit-protocol/e2epackage by using the package's public API instead of deep imports - Added BigInt serialization support in StateManager to prevent JSON serialization errors
- Added Artillery load testing documentation with setup, initialization, and workload execution instructions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/artillery/src/init.ts | Consolidated imports to use @lit-protocol/e2e package exports instead of deep paths |
| packages/artillery/src/StateManager.ts | Added stringify helper function with BigInt replacer to handle BigInt JSON serialization |
| README.md | Added comprehensive Artillery load testing documentation including setup, initialization, and workload scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const stringify = (value: unknown) => | ||
| JSON.stringify( | ||
| value, | ||
| (_, val) => (typeof val === 'bigint' ? val.toString() : val), | ||
| 2 | ||
| ); |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stringify function lacks documentation explaining its purpose. Add a JSDoc comment explaining that it serializes objects to JSON with BigInt support, as BigInt values cannot be directly serialized by JSON.stringify.
…guring local network testing
…ndle key recording
WHAT
HOW TO RUN
pnpm nx run artillery:initpnpm nx run artillery:balance-statuspnpm nx run artillery:run:pkp-sign