Skip to content

Conversation

@Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Nov 5, 2025

WHAT

  • resolve Artillery init so it consumes exported helpers and writes state containing bigint values
  • add docs for Artillery

HOW TO RUN

  • pnpm nx run artillery:init
  • (optional) pnpm nx run artillery:balance-status
  • pnpm nx run artillery:run:pkp-sign

Copilot AI review requested due to automatic review settings November 5, 2025 17:09
@Ansonhkg Ansonhkg self-assigned this Nov 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates import paths for Artillery utilities and adds BigInt serialization support to the state manager, along with comprehensive documentation for Artillery load testing.

  • Simplified imports from @lit-protocol/e2e package by using the package's public API instead of deep imports
  • Added BigInt serialization support in StateManager to prevent JSON serialization errors
  • Added Artillery load testing documentation with setup, initialization, and workload execution instructions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/artillery/src/init.ts Consolidated imports to use @lit-protocol/e2e package exports instead of deep paths
packages/artillery/src/StateManager.ts Added stringify helper function with BigInt replacer to handle BigInt JSON serialization
README.md Added comprehensive Artillery load testing documentation including setup, initialization, and workload scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +155 to +160
const stringify = (value: unknown) =>
JSON.stringify(
value,
(_, val) => (typeof val === 'bigint' ? val.toString() : val),
2
);
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stringify function lacks documentation explaining its purpose. Add a JSDoc comment explaining that it serializes objects to JSON with BigInt support, as BigInt values cannot be directly serialized by JSON.stringify.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants