Add support for platform specific localized display names for DayOfWeek and Month #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
Some context:
java.time.Month.getDisplayNameandjava.time.DayOfWeek.getDisplayNameand I miss that functionalityjvmanddarwintargets using aLocaleand ajava.time.format.TextStyleinspiredTextStyle.I've added
DayOfWeekNames.ENGLISH_NARROWandMonthNames.ENGLISH_NARROWto use together with theENGLISH_FULLandENGLISH_ABBREVIATEDas fallback fordisplayName.These were defined as
List<String>because could contain duplicate entries, to not accidentally pass them to theDateTimeFormatBuilderwhich currently expects different entries for day/month names.I'm looking forward to your feedback and in the meantime I'll be using this: https://github.com/adrcotfas/kotlinx-datetime-names (there's a demo there).