Skip to content

tiny refactor. just adding steps to the e2e extrude test #9146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-mrgrsk merged 5 commits into from
Dec 3, 2025
Merged

tiny refactor. just adding steps to the e2e extrude test #9146

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0c57e4
just adding steps to the test
max-mrgrsk Dec 2, 2025
35fe241
Merge branch 'main' into max/extrude-test-refacor
max-mrgrsk Dec 2, 2025
0e43f2e
Merge branch 'main' into max/extrude-test-refacor
max-mrgrsk Dec 2, 2025
e70bfc4
Merge branch 'main' into max/extrude-test-refacor
jacebrowning Dec 2, 2025
627ffce
Merge branch 'main' into max/extrude-test-refacor
jacebrowning Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 98 additions & 79 deletions e2e/playwright/point-click.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,96 +122,115 @@ test.describe('Point-and-click tests', () => {
}) => {
const code = `sketch001 = startSketchOn(XY)
profile001 = circle(sketch001, center = [0, 0], radius = 5)`
await context.addInitScript((initialCode) => {
localStorage.setItem('persistCode', initialCode)
}, code)
await homePage.goToModelingScene()
await scene.settled(cmdBar)
await test.step('Settle the scene', async () => {
await context.addInitScript((initialCode) => {
localStorage.setItem('persistCode', initialCode)
}, code)
await page.setBodyDimensions({ width: 1000, height: 500 })
await homePage.goToModelingScene()
await scene.settled(cmdBar)
})

await test.step('Add extrude with tags', async () => {
await toolbar.extrudeButton.click()
await editor.selectText('circle')
await cmdBar.progressCmdBar()
await cmdBar.clickOptionalArgument('length')
await cmdBar.expectState({
stage: 'arguments',
currentArgKey: 'length',
currentArgValue: '5',
headerArguments: {
Profiles: '1 profile',
Length: '',
},
highlightedHeaderArg: 'length',
commandName: 'Extrude',
await test.step('Open extrude command from toolbar', async () => {
await toolbar.extrudeButton.click()
})
await page.keyboard.insertText('4')
await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: {
Length: '4',
Profiles: '1 profile',
},
commandName: 'Extrude',
await test.step('Select profile', async () => {
await editor.selectText('circle')
await cmdBar.progressCmdBar()
})
await cmdBar.clickOptionalArgument('tagEnd')
await cmdBar.expectState({
stage: 'arguments',
currentArgKey: 'tagEnd$',
currentArgValue: '',
headerArguments: {
Length: '4',
Profiles: '1 profile',
TagEnd: '',
},
highlightedHeaderArg: 'tagEnd',
commandName: 'Extrude',
await test.step('Set length', async () => {
await cmdBar.clickOptionalArgument('length')
await cmdBar.expectState({
stage: 'arguments',
currentArgKey: 'length',
currentArgValue: '5',
headerArguments: {
Profiles: '1 profile',
Length: '',
},
highlightedHeaderArg: 'length',
commandName: 'Extrude',
})
await page.keyboard.insertText('4')
await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: {
Length: '4',
Profiles: '1 profile',
},
commandName: 'Extrude',
})
})
await page.keyboard.insertText('myEndTag')
await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: {
Length: '4',
Profiles: '1 profile',
TagEnd: 'myEndTag',
},
commandName: 'Extrude',
await test.step('Set end tag', async () => {
await cmdBar.clickOptionalArgument('tagEnd')
await cmdBar.expectState({
stage: 'arguments',
currentArgKey: 'tagEnd$',
currentArgValue: '',
headerArguments: {
Length: '4',
Profiles: '1 profile',
TagEnd: '',
},
highlightedHeaderArg: 'tagEnd',
commandName: 'Extrude',
})
await page.keyboard.insertText('myEndTag')
await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: {
Length: '4',
Profiles: '1 profile',
TagEnd: 'myEndTag',
},
commandName: 'Extrude',
})
})
await test.step('Submit and verify', async () => {
await cmdBar.submit()
await editor.expectEditor.toContain(
'extrude(profile001, length = 4, tagEnd = $myEndTag)'
)
})
await cmdBar.submit()
await editor.expectEditor.toContain(
'extrude(profile001, length = 4, tagEnd = $myEndTag)'
)
})

await test.step(`Edit first extrude via feature tree`, async () => {
await (await toolbar.getFeatureTreeOperation('Extrude', 0)).dblclick()
await cmdBar.clickHeaderArgument('length')
await cmdBar.expectState({
stage: 'arguments',
currentArgKey: 'length',
currentArgValue: '4',
headerArguments: {
Length: '4',
TagEnd: 'myEndTag',
},
highlightedHeaderArg: 'length',
commandName: 'Extrude',
await test.step('Open extrude operation from feature tree', async () => {
await (await toolbar.getFeatureTreeOperation('Extrude', 0)).dblclick()
})
await page.keyboard.insertText('3')
await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: {
Length: '3',
TagEnd: 'myEndTag',
},
commandName: 'Extrude',
await test.step('Edit length argument', async () => {
await cmdBar.clickHeaderArgument('length')
await cmdBar.expectState({
stage: 'arguments',
currentArgKey: 'length',
currentArgValue: '4',
headerArguments: {
Length: '4',
TagEnd: 'myEndTag',
},
highlightedHeaderArg: 'length',
commandName: 'Extrude',
})
await page.keyboard.insertText('3')
await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: {
Length: '3',
TagEnd: 'myEndTag',
},
commandName: 'Extrude',
})
})
await test.step('Submit and verify', async () => {
await cmdBar.submit()
await editor.expectEditor.toContain(
'extrude(profile001, length = 3, tagEnd = $myEndTag)'
)
})
await cmdBar.progressCmdBar()
await editor.expectEditor.toContain(
'extrude(profile001, length = 3, tagEnd = $myEndTag)'
)
})
})

Expand Down
Loading