-
Notifications
You must be signed in to change notification settings - Fork 43
Fix vector size for presentCompleteSemaphores. #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Definitively yes. Without this change, the tutorial is not spec compliant, see #65 |
0faa53f to
9a803ea
Compare
9a803ea to
dd21bdc
Compare
SaschaWillems
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, but tutorial text needs to be adjusted to. Did a quick compare of the frames in flight chapter, and it no longer matches the semaphore setup now used in code.
If you could give me a hint, where the corresponding tutorial text is, I could try to adjust it accordingly. |
|
E.g. "03_Frames_in_flight.adoc". Looking at this, it does at least partially differ from the updated code and might need to be updated. |
|
@SaschaWillems Ok, I've adjusted some documentation. Please have a closer look at it! |
14866cd to
7e93cd5
Compare
7e93cd5 to
94768d7
Compare
Only the semaphores signalled on finished rendering need to be indexed by the image index. All other resources (command buffers, fences, semaphores signalled on present completion) are indexed by the frame index.
Includes some minor clean-up on chapter 15 as well.
As usual, if this is considered to be ok, I can carry this change to all the other chapters.