Bump js-yaml to v4.1.1 #297
Merged
+7
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
added
maintenance
krassowski
reviewed
Dec 9, 2025
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Contributor
🚀 PR Environment Deployment StartedInfrastructure deployment has been triggered after all checks passed. Backend Version: Frontend Ref: You can monitor the deployment progress in the infrastructure repository. 📜 Previous Deployments
Deployment initiated at 2025-12-10T09:37:47.623Z |
krassowski
approved these changes
Dec 10, 2025
Collaborator
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
Looking a bit more into this:
- I think it should be possible to avoid the resolution pin - there are patched versions on both 4.x and 3.x branches of js-yaml
- why do we need the 3.x one and why did it not break? I think because it is only used by a babel plugin used for unit tests and we don't really have unit tests
My suggestion would be to drop the resolution pin AND:
- just use
jlpm upgrade-interactiveto bump the versions granularly OR - drop the unit tests machinery altogether since we are testing everything via playwright (which makes sense for this project)
Anyways, since the resolution pin as is has no bearing on the runtime I am approving this - the follow up work can be done in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to recreate #294 but with
jlpmhandling things instead ofyarnor otherwise. The pre-commit failure will be handled by #296.