Do not (mis)use objective as state #1212
Merged
+1,037
−986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
2 times, most recently
from
935c749 to
93e8f31
Compare
pkofod
reviewed
Nov 26, 2025
| end | ||
|
|
||
| if g_calls(d) > 0 && !all(isfinite, gradient(d)) | ||
| if hasproperty(state, :g_x) && !all(isfinite, state.g_x) |
Member
There was a problem hiding this comment.
could in principle add methods to isfinite_gradient and isfinite_hessian that you introduced for the objective? I suppose they are sufficiently similar in nature to share the function?
Member
There was a problem hiding this comment.
if it's only used once of course... then it's maybe overkill :) I suppose in termination code as well..
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
6 times, most recently
from
c4d1eec to
d2071a1
Compare
pkofod
reviewed
Nov 27, 2025
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
from
8c40315 to
60a5fef
Compare
Contributor
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
A plot of the benchmark results has been uploaded as an artifact at . |
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
5 times, most recently
from
938f2ec to
95ca2d8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 87.32% 86.77% -0.55%
==========================================
Files 45 45
Lines 3558 3539 -19
==========================================
- Hits 3107 3071 -36
- Misses 451 468 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
from
95ca2d8 to
92ae7aa
Compare
devmotion
changed the title
devmotion
force-pushed
the
dmw/do_not_misuse_objective_as_state
branch
from
92ae7aa to
6182632
Compare
Member
|
I suppose the artifacts need to be uniquely named |
Contributor
Author
|
Indeed, I already opened a PR on Friday: MilesCranmer/AirspeedVelocity.jl#120 |
pkofod
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much WIP, and I might have to start over again. Fixes #1210 (comment) by not (mis)using objective functions as states. Instead, this PR proposes to add
f_xandg_xfields to the optimization states (where needed), similar to already existingx_previous,f_x_previousandg_x_previousfields.