Skip to content

Conversation

@nhz2
Copy link
Member

@nhz2 nhz2 commented Nov 7, 2025

This adds back in the constructor that was removed in #84 and includes a deprecation warning.

Claude wrote the warning.

@nhz2 nhz2 requested a review from mkitti November 7, 2025 22:10
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.98%. Comparing base (f8c6b20) to head (7f68f91).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/compression.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   64.35%   60.98%   -3.37%     
==========================================
  Files           4        4              
  Lines         390      364      -26     
==========================================
- Hits          251      222      -29     
- Misses        139      142       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkitti
Copy link
Member

mkitti commented Nov 8, 2025

Did something come up requiring it?

@nhz2
Copy link
Member Author

nhz2 commented Nov 8, 2025

No, I think this method can be deleted after the next release.

@nhz2 nhz2 merged commit 9979620 into master Nov 8, 2025
16 of 18 checks passed
@nhz2 nhz2 deleted the nz/deprecate-constructor branch November 8, 2025 01:36
@nhz2 nhz2 mentioned this pull request Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants