-
Notifications
You must be signed in to change notification settings - Fork 46
Disable broken vectorization tests on Windows and use windows-2022 in CI
#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 12 12
Lines 730 730
=======================================
Hits 589 589
Misses 141 141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@simeonschaub seems like #379 introduced windows test failures (other than #317) masked by the windows-2025 runners breaking |
|
Hmm, that's odd! I'd be fine with skipping these tests on windows for now, but would be good to figure out why pocl does not support explicit SIMD on these platforms. |
9dcc57f to
45b73b6
Compare
45b73b6 to
538bb2f
Compare
windows-2022 in CI until windows-2025 is fixedwindows-2022 in CI
windows-2022 in CIwindows-2022 in CI
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/runtests.jl b/test/runtests.jl
index ddf62c7..a73db1f 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -1,5 +1,5 @@
using Pkg
-Pkg.add(url="https://github.com/JuliaGPU/GPUArrays.jl", rev="splittest")
+Pkg.add(url = "https://github.com/JuliaGPU/GPUArrays.jl", rev = "splittest")
using Distributed
using Dates |
7cefd1d to
4c3ab5d
Compare
4c3ab5d to
97ac8c1
Compare
a4f0f03 to
97ac8c1
Compare
No description provided.