Skip to content

Using SDK Version variables from root project #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Using SDK Version variables from root project #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
988aec3
Using SDK Version variables from root project
rayronvictor Apr 24, 2018
9ba6712
revert gradle plugin to 2.2.3
rayronvictor Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,21 @@ buildscript {

apply plugin: 'com.android.library'

def _ext = rootProject.ext

def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+'
def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 27
def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '27.0.3'
def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16
def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 27

android {
compileSdkVersion 23
buildToolsVersion "23.0.1"
compileSdkVersion _compileSdkVersion
buildToolsVersion _buildToolsVersion

defaultConfig {
minSdkVersion 16
targetSdkVersion 22
minSdkVersion _minSdkVersion
targetSdkVersion _targetSdkVersion
versionCode 1
versionName "1.0"
externalNativeBuild {
Expand All @@ -30,20 +38,20 @@ android {
abiFilters = project(":app").android.defaultConfig.ndk.abiFilters
}
}

externalNativeBuild {
cmake {
path "CMakeLists.txt"
}
}

sourceSets {
main {
jniLibs.srcDirs 'libnode/bin/'
}
main.assets.srcDirs += '../install/resources/nodejs-modules'
}

lintOptions {
abortOnError false
}
Expand All @@ -54,7 +62,8 @@ repositories {
}

dependencies {
compile 'com.facebook.react:react-native:+'
//noinspection GradleDynamicVersion
compile "com.facebook.react:react-native:${_reactNativeVersion}"
}

task CopyNodeProjectAssetsFolder (type:Sync) {
Expand Down Expand Up @@ -341,4 +350,4 @@ if ("1".equals(shouldRebuildNativeModules)) {
tasks.getByPath(":${project.name}:preBuild").dependsOn "GenerateNodeNativeAssetsLists${abi_name}"
}
project.android.sourceSets.main.assets.srcDirs+="${rootProject.buildDir}/nodejs-native-assets/"
}
}