-
Notifications
You must be signed in to change notification settings - Fork 168
1995 offchain voting json #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7c299d2 to
f6f66ee
Compare
kderme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small code reduction
f6f66ee to
f24d86a
Compare
0c34e87 to
7cfd660
Compare
Wasnt the issue about storing data if hash matches regardless of whether it conforms to a standard or not (as there will be multiple standards) leaving conformance to consumers? This does not sound like it is exactly addressing the request |
Note that we already store bytes in off_chain_vote_data.bytes for metadata. You can get the original text using After this pr this is always included as long as the bytes hash match the expected (and the http header is reasonable) |
It is only stored if metadata returned is considered valid/parsable (atleast before), glad if that's changing now |
This changes with this pr. The offchain and the byte will exist even if the json parsing fails. A separate field will annotate that parsing failed |
In it's current state, we're unable to build cardana-chain-gen:
cannot find -lpgcommon: No such file or directory
cannot find -lpgport: No such file or directory
collect2: error: ld returned 1 exit status
Remove the extra configure flags, and see if we can still build all the
other artifacts.
421ff32 to
19a7e04
Compare
This PR implements graceful handling of off-chain voting anchor metadata based on parsing success.
fixes #1995
When the anchor hash matches, data is stored with an
is_validflag indicating:Hash mismatches continue to go to the error table for retry. Tests and documentation updated accordingly.