Skip to content

Xform_bitslices bugfix #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Xform_bitslices bugfix #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libASL/xform_bitslices.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ open Asl_utils
open Builtin_idents
open Utils

let is_constant (x : AST.expr) : bool =
( match x with
| Expr_Lit _ -> true
| _ -> false
)

let transform_slices : bool ref = ref true

let transform_non_slices (n : AST.expr) (w : AST.expr) (i : AST.expr)
Expand Down Expand Up @@ -55,7 +61,7 @@ let transform (loc : Loc.t) (n : AST.expr) (w : AST.expr) (i : AST.expr)
| Expr_Slices (_, _, [Slice_Single _]) ->
raise (InternalError
(loc, "Slice_Single not expected", (fun fmt -> Asl_fmt.expr fmt x), __LOC__))
| Expr_Slices (Type_Bits (we, _), e, [Slice_LoWd (lo, wd)]) ->
| Expr_Slices (Type_Bits (we, _), e, [Slice_LoWd (lo, wd)]) when not (is_constant wd) ->
(* generate "zero_extend_bits((e >> lo) AND mk_mask(wd, we), n) << i" *)
let e1 = mk_lsr_bits we e lo in
let e2 = mk_and_bits we e1 (Asl_utils.mk_mask wd we) in
Expand Down
Loading