Skip to content

Conversation

@Infinitay
Copy link
Owner

WIP for more highlight modes support. Already have the basis and currently working on refactoring before implementing

  • Add support for starting the plugin already in the instance
    • Tested and working
  • Add configurable highlight options (Gravestone Icon, Coffin Icon, Highlight Grave, Highlight Coffin, Gravestone Text, Coffin Text)
    • Basic implementation of options and config changes
  • Change the item icons into skill icons instead
    • Implemented but haven't tested

feat(gravedigger): Add support for starting in event (#28)

  • Added proper support for handling initial runs when (re)starting the plugin when already inside the random event

- Added proper support for handling initial runs when (re)starting the plugin when already inside the random event
@Infinitay Infinitay added enhancement New feature or request gravedigger Gravedigger module implementing Actively working on this issue/PR labels Nov 29, 2025
- Extracted rendering code into dedicated methods for better readability and maintainability.
- Preparing for the future rendering modes implementation
	- Conditionals/options
@Infinitay
Copy link
Owner Author

refactor(gravedigger): Refactored rendering into separate methods

  • Extracted rendering code into dedicated methods for better readability and maintainability.
  • Preparing for the future rendering modes implementation
    • Conditionals/options

…d injection)

- Removed field injection dependency on GravediggerOverlay within GravediggerHelper
- Added GravediggerOverlay field injection within RandomEventHelperPlugin
- Now using method injection for GravediggerOverlay dependency within RandomEventHelperPlugin onto GravediggerHelper#startUp
@Infinitay
Copy link
Owner Author

The latest commit fixes a circular dependency issue I was having when attempting to add RandomEventHelperConfig to GravediggerOverlay's constructor injection. I've exhausted my attempted at switching to using Provider, but it kept resulting in the same error regarding java.lang.IllegalStateException: Recursive load of: randomeventhelper.randomevents.gravedigger.GravediggerHelper.<init>(). As a result, I ended up relying on injecting the GravediggerOverlay into RandomEventHelperPlugin and modify GravediggerHelper#startUp to have the parameter of GravediggerOverlay - method injection.

This sets up future feature additions for optional highlights and to use skill icons instead of item icons.

fix(gravedigger): Fixed GravediggerOverlay circular dependency (method injection)

  • Removed field injection dependency on GravediggerOverlay within GravediggerHelper
  • Added GravediggerOverlay field injection within RandomEventHelperPlugin
  • Now using method injection for GravediggerOverlay dependency within RandomEventHelperPlugin onto GravediggerHelper#startUp

- Added the option to select between showing skill icons or item icons related to the respective grave
- Added skill icon support to the Coffin object
	- Added Sprite ID for the related skill icon to the enums via associatedSkillSpriteID
	- Added #getSkillIconImage for fetching the BufferedImage of the skill
- Fetch skill icons from the SpriteManager via Coffin class and store them into the new coffinSkillImageMap
- Conditionally render skill or item icon within the overlay depending on config value
- Refactored config options by removing Options config section and re-ordering existing config
- Now adding sections for configurable modules with more options such as FreakyForester and Gravedigger
- Added gravediggerUseSkillIcons config option to use skill icons instead of item icons
@Infinitay
Copy link
Owner Author

feat(gravedigger): Add support for choosing between skill or item icons

  • Added the option to select between showing skill icons or item icons related to the respective grave
  • Added skill icon support to the Coffin object
    • Added Sprite ID for the related skill icon to the enums via associatedSkillSpriteID
    • Added #getSkillIconImage for fetching the BufferedImage of the skill
  • Fetch skill icons from the SpriteManager via Coffin class and store them into the new coffinSkillImageMap
  • Conditionally render skill or item icon within the overlay depending on config value
  • Refactored config options by removing Options config section and re-ordering existing config
  • Now adding sections for configurable modules with more options such as FreakyForester and Gravedigger
  • Added gravediggerUseSkillIcons config option to use skill icons instead of item icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gravedigger Gravedigger module implementing Actively working on this issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants