issue/695 c++ infinicore::nn::module支持bf16 #696
+81
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ceng23333 <441651826@qq.com>
PanZezhong1725
requested changes
Dec 2, 2025
Signed-off-by: Ceng23333 <441651826@qq.com>
wooway777
requested changes
Dec 2, 2025
| // Create CPU tensors and copy data | ||
| auto sin_cpu = Tensor::from_blob(sin_data.data(), {max_seq_len_, cache_dim}, DataType::F32, cpu_device); | ||
| auto cos_cpu = Tensor::from_blob(cos_data.data(), {max_seq_len_, cache_dim}, DataType::F32, cpu_device); | ||
| // Convert to target dtype on CPU (matching Python's numpy astype conversion pattern) |
pengcheng888
reviewed
Dec 2, 2025
src/infinicore/nn/embedding.cc
Outdated
| num_lookups *= dim; | ||
| } | ||
|
|
||
| const size_t row_bytes = embedding_dim_ * (weight_->dtype() == DataType::F32 ? sizeof(float) : weight_->dtype() == DataType::BF16 ? sizeof(uint16_t) |
Contributor
There was a problem hiding this comment.
infinicore::DataType有 dsize函数，可以调用
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
wooway777
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#695