issue/338: infinirt适配虚存接口 #341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ceng <441651826@qq.com>
Ceng23333
requested review from
PanZezhong1725 and
YdrMaster
and removed request for
PanZezhong1725
YdrMaster
suggested changes
Aug 5, 2025
PanZezhong1725
requested changes
Aug 5, 2025
include/infinirt.h
Outdated
| }; | ||
|
|
||
| // Represents a vacant region, storing its length. | ||
| using infinirtVacantRegion = size_t; |
Collaborator
There was a problem hiding this comment.
using？这是纯C语言头文件，不能有std之类的C++语法
include/infinirt.h
Outdated
| typedef void *infinirtAllocationHandle_t; | ||
|
|
||
| // Represents a physical memory allocation, mirroring Rust's PhyMem. | ||
| struct infinirtPhyMem { |
Collaborator
|
先把document写了提pr |
PanZezhong1725
requested changes
Aug 5, 2025
include/infinirt.h
Outdated
| // A region in virtual memory can be either mapped or vacant. | ||
| using infinirtPhyRegion = std::variant<infinirtMappedRegion, infinirtVacantRegion>; | ||
|
|
||
| struct infinirtVirtualMemManager { |
Collaborator
There was a problem hiding this comment.
这个库只提供接口就可以，不需要提供一个manager，用户自己负责管理虚存和物理内存的表
Signed-off-by: Ceng <441651826@qq.com>
Signed-off-by: Ceng <441651826@qq.com>
Signed-off-by: Ceng <441651826@qq.com>
YdrMaster
suggested changes
Aug 13, 2025
| __C __export infiniStatus_t infinirtReleasePhysicalMem(infinirtPhysicalMemoryHandle_t pm_handle); | ||
|
|
||
| __C __export infiniStatus_t infinirtCreateVirtualMem(void **vm, size_t len); | ||
| __C __export infiniStatus_t infinirtMapVirtualMem(void *vm, size_t len, size_t offset, infinirtPhysicalMemoryHandle_t pm_handle); |
| // Virtual memory & physical memory | ||
| typedef void *infinirtPhysicalMemoryHandle_t; | ||
|
|
||
| __C __export infiniStatus_t infinirtGetMemGranularityMinimum(size_t *granularity); |
Contributor
There was a problem hiding this comment.
我觉得 CUDA 搞这个名字挺奇怪的，要是想跟 CUDA 对齐就保持，不然的话叫 page size 之类的更好些
| return freeDevice(ptr); | ||
| } | ||
|
|
||
| infiniStatus_t getMemGranularityMinimum(size_t *granularity) { |
Contributor
There was a problem hiding this comment.
CPU 主存很容易实现虚拟化逻辑，没必要设置为不支持。可以手工做一套用户态虚拟化或者交由操作系统处理（主存正常分配自带操作系统提供的虚拟化）
| #include "infinirt_cuda.cuh" | ||
| #include <cuda.h> | ||
| #include <cuda_runtime.h> | ||
| #include <string.h> |
Contributor
There was a problem hiding this comment.
.cu 里面理论上说不需要 cuda.h、cuda_runtime.h 对于 nvcc 来说是预置的。c/c++ 标准库头文件应该用 c++ 标准的
| CUmemAllocationProp *getMemProp() { | ||
| int device_id; | ||
| infinirtGetDevice(nullptr, &device_id); | ||
| CUmemAllocationProp *cuda_prop = new CUmemAllocationProp(); |
PanZezhong1725
requested changes
Aug 14, 2025
| } | ||
|
|
||
| infiniStatus_t getMemGranularityMinimum(size_t *granularity) { | ||
| CUmemAllocationProp *cuda_prop = getMemProp(); |
Collaborator
There was a problem hiding this comment.
这里用
CUmemAllocationProp cuda_prop;
getMemProp()可以传它的地址
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#338