Issue/259 add softmax operator #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziminli
requested changes
Jun 16, 2025
Ziminli
requested changes
Jun 23, 2025
| } | ||
| }; | ||
|
|
||
| template <typename T, template <typename> class ReduceOp, int thread_group_width = 32> |
Collaborator
There was a problem hiding this comment.
（line 50）常数最好是全大写 snake_case
Comment on lines
79
to
81
| template <int elemPerThread, int BLOCK_DIM_Y, int BLOCK_DIM_X, typename T> | ||
| __global__ void Softmax_warp_impl(const T *x, T *y, int stride, int dimsize, int otherdim_size) { | ||
| float dataPerThread[elemPerThread]; |
Collaborator
|
测试框架有重构，请rebase最新代码做相应更改 |
Graylatzhou
force-pushed
the
softmax-feature
branch
from
3b4e020 to
45e789e
Compare
Graylatzhou
force-pushed
the
softmax-feature
branch
from
45e789e to
56b4900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.