Skip to content

fix(radio): style component using sass theme #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
Merged

fix(radio): style component using sass theme #1980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d40116
fix(radio): style component using sass theme
SisIvanova Nov 17, 2025
9cb31da
Merge branch 'master' into sivanova/radio-styling
didimmova Nov 17, 2025
e6f059f
fix(radio): invalid hover state
SisIvanova Nov 17, 2025
1d96d41
Merge branch 'master' into sivanova/radio-styling
rkaraivanov Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/components/radio/themes/shared/radio.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ $theme: $bootstrap;
width: var(--size);
height: var(--size);
min-width: var(--size);
background: var-get($theme, 'empty-fill-color');
transition: transparent;

&::before,
Expand Down Expand Up @@ -86,6 +85,10 @@ $theme: $bootstrap;
background: var-get($theme, 'fill-color-hover');
border-color: var-get($theme, 'fill-color-hover');
}

&::before {
background: var-get($theme, 'fill-hover-border-color');
}
}

[part~='focused'] [part='control'] {
Expand Down Expand Up @@ -114,10 +117,6 @@ $theme: $bootstrap;

:host(:not([disabled]):state(ig-invalid):hover),
:host(:not(:disabled):state(ig-invalid):hover) {
[part~='control']::after {
border-color: var-get($theme, 'error-color-hover');
}

[part='control checked'] {
&::after {
background: var-get($theme, 'error-color-hover');
Expand All @@ -127,16 +126,14 @@ $theme: $bootstrap;

:host([disabled]),
:host(:disabled) {
[part='control'] {
&::after {
border-color: var-get($theme, 'disabled-color');
[part='control checked'] {
&::before {
background: var-get($theme, 'fill-hover-border-color');
border-color: var-get($theme, 'fill-hover-border-color');
}
}

[part='control checked'] {
&::after {
background: var-get($theme, 'disabled-fill-color');
border-color: var-get($theme, 'disabled-fill-color');
}
}
}
49 changes: 48 additions & 1 deletion src/components/radio/themes/shared/radio.common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,64 @@
@use 'styles/utilities' as *;
@use '../light/themes' as *;

$theme: $base;
$theme: $material;

[part~='label'] {
color: var-get($theme, 'label-color');
}

[part~='base']:hover {
[part~='label'] {
color: var-get($theme, 'label-color-hover');
}
}

[part~='control'] {
background: var-get($theme, 'empty-fill-color');
}

:host(:hover) {
[part='control checked'] {
&::before {
background: var-get($theme, 'fill-color-hover');
border: rem(2px) solid var-get($theme, 'fill-hover-border-color');
}

&::after {
border-color: var-get($theme, 'fill-hover-border-color');
}
}
}

:host(:not([disabled]):state(ig-invalid):hover),
:host(:not(:disabled):state(ig-invalid):hover) {
[part~='control']::after {
border-color: var-get($theme, 'error-color-hover');
}
}

:host([disabled]),
:host(:disabled) {
[part~='label'] {
color: var-get($theme, 'disabled-label-color');
}

[part~='control'] {
&::after {
border-color: var-get($theme, 'disabled-color');
}
}

[part='control checked'] {
&::before {
background: var-get($theme, 'disabled-fill-color');
border-color: var-get($theme, 'disabled-fill-color');
}

&::after {
border-color: var-get($theme, 'disabled-fill-color');
}
}
}

:host(:not([disabled]):state(ig-invalid)),
Expand Down
23 changes: 2 additions & 21 deletions src/components/radio/themes/shared/radio.fluent.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,18 +104,14 @@ $theme: $fluent;

&::before {
background: var-get($theme, 'fill-color-hover');
border-color: var-get($theme, 'fill-hover-border-color');
border: rem(1px) solid var-get($theme, 'fill-hover-border-color');
}
}
}

:host(:not([disabled]):state(ig-invalid):hover),
:host(:not(:disabled):state(ig-invalid):hover) {
[part='control'] {
&::after {
border-color: var-get($theme, 'error-color-hover');
}

&::before {
background: var-get($theme, 'error-color');
}
Expand All @@ -128,6 +124,7 @@ $theme: $fluent;

&::before {
background: var-get($theme, 'error-color-hover');
border-color: var-get($theme, 'error-color-hover');
}
}
}
Expand Down Expand Up @@ -156,19 +153,3 @@ $theme: $fluent;
}
}
}

:host([disabled]),
:host(:disabled) {
[part~='control'] {
&::after {
border-color: var-get($theme, 'disabled-color');
}
}

[part='control checked'] {
&::before {
background: var-get($theme, 'disabled-color');
border-color: var-get($theme, 'disabled-color');
}
}
}
60 changes: 15 additions & 45 deletions src/components/radio/themes/shared/radio.indigo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,22 @@ $theme: $indigo;
}
}

[part~='base'] {
gap: rem(8px);
:host(:hover) {
[part~='control']::after {
border: rem(2px) solid var-get($theme, 'hover-color');
}

&:hover {
[part~='label'] {
color: var-get($theme, 'label-color-hover');
}
[part='control checked']::after {
border-color: var-get($theme, 'fill-hover-border-color');
}
}

[part~='base'] {
gap: rem(8px);
}

[part~='label'] {
@include type-style('body-2');

color: var-get($theme, 'label-color');
}

[part~='control'] {
Expand All @@ -36,7 +38,6 @@ $theme: $indigo;
height: var(--size, rem(20px));
min-width: var(--size, rem(20px));
transition: none;
background: none;

&::before,
&::after {
Expand All @@ -46,12 +47,6 @@ $theme: $indigo;
&::after {
border: rem(2px) solid var-get($theme, 'empty-color');
}

&:hover {
&::after {
border: rem(2px) solid var-get($theme, 'hover-color');
}
}
}

[part='control checked'] {
Expand Down Expand Up @@ -96,20 +91,14 @@ $theme: $indigo;
}
}

[part='label'] {
[part~='label'] {
color: var-get($theme, 'label-color');
}

[part='control'] {
&::after {
border-color: var-get($theme, 'error-color');
}

&:hover {
&::after {
border-color: var-get($theme, 'error-color-hover');
}
}
}

[part='control checked'] {
Expand All @@ -120,16 +109,6 @@ $theme: $indigo;
&::before {
background: var-get($theme, 'error-color');
}

&:hover {
&::after {
border-color: var-get($theme, 'error-color-hover');
}

&::before {
background: var-get($theme, 'error-color-hover');
}
}
}

[part~='focused'] {
Expand All @@ -140,21 +119,12 @@ $theme: $indigo;
}
}

:host([disabled]),
:host(:disabled) {
[part='control'] {
&::after {
border-color: var-get($theme, 'disabled-color');
}
}

:host(:not([disabled]):state(ig-invalid):hover),
:host(:not(:disabled):state(ig-invalid):hover) {
[part='control checked'] {
&::after {
border-color: var-get($theme, 'disabled-fill-color');
}

&::before {
background: var-get($theme, 'disabled-fill-color');
background: var-get($theme, 'error-color-hover');
border-color: var-get($theme, 'error-color-hover');
}
}
}
26 changes: 14 additions & 12 deletions src/components/radio/themes/shared/radio.material.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ $theme: $material;
[part~='control'] {
border-radius: var(--size);
position: relative;
background: unset;

&::before,
&::after {
Expand All @@ -65,6 +66,7 @@ $theme: $material;

&::after {
border: calc(var(--size) / 10) solid var-get($theme, 'empty-color');
background: var-get($theme, 'empty-fill-color');
}
}

Expand All @@ -81,10 +83,8 @@ $theme: $material;

:host(:not([disabled]):state(ig-invalid)),
:host(:not(:disabled):state(ig-invalid)) {
[part~='control'] {
&::after {
border-color: var-get($theme, 'error-color');
}
[part~='control']::after {
border-color: var-get($theme, 'error-color');
}

[part='control checked'] {
Expand All @@ -109,18 +109,20 @@ $theme: $material;
}
}

:host([disabled]),
:host(:disabled) {
[part~='control'] {
&::after {
border-color: var-get($theme, 'disabled-color');
}
:host(:not([disabled]):state(ig-invalid):hover),
:host(:not(:disabled):state(ig-invalid):hover) {
[part~='control']::after {
border-color: var-get($theme, 'error-color');
}

[part='control checked'] {
&::before {
background: var-get($theme, 'disabled-color');
border-color: var-get($theme, 'disabled-color');
background: var-get($theme, 'error-color-hover');
border-color: var-get($theme, 'error-color-hover');
}

&::after {
border-color: var-get($theme, 'error-color-hover');
}
}
}
Loading