-
Notifications
You must be signed in to change notification settings - Fork 17
feat: implement mapping configuration between record types and messengers #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: alvarolopez <468751+alvarolopez@users.noreply.github.com>
…ering Co-authored-by: alvarolopez <468751+alvarolopez@users.noreply.github.com>
|
@copilot Will this setup generate the correct sample configuration file? Taking into account that you are registering the options in the manager, when generating the options via oslo, these will not be set. |
Co-authored-by: alvarolopez <468751+alvarolopez@users.noreply.github.com>
Yes, the sample configuration file is correctly generated. The options are defined in |
|
@copilot There are two more things missing:
|
Co-authored-by: alvarolopez <468751+alvarolopez@users.noreply.github.com>
Added documentation for messenger record type filtering in |
|
@copilot caso/messenger/init.py:152 make those lines simpler: |
Co-authored-by: alvarolopez <468751+alvarolopez@users.noreply.github.com>
|
@copilot please include a release notes file, documenting this new behaviour. Although this does not change the behaviour (as we have the defaults) this should be documented. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
=========================================
Coverage ? 60.68%
=========================================
Files ? 24
Lines ? 1343
Branches ? 129
=========================================
Hits ? 815
Misses ? 505
Partials ? 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: alvarolopez <468751+alvarolopez@users.noreply.github.com>
Added release notes in 035010c. The file documents the new features (per-messenger record type filtering, default behaviors for SSM and other messengers) and includes upgrade notes explaining how to enable energy records for SSM. |
|
|



Description
Adds per-messenger configuration to control which record types are published. Previously all records were sent to all messengers. Now users can configure
record_typesper messenger section.Default behavior:
ssm,ssmv4): Only records from default extractors (cloud,ip,accelerator,storage)noop,logstash): All record typesConfiguration example:
Changes:
caso/messenger/__init__.py: Added_filter_records(),get_messenger_opts(),register_messenger_opts(), and per-messenger filtering inManager.push_to_all()caso/opts.py: Added messenger-specificrecord_typesoptions tolist_opts()etc/caso/caso.conf.sample: Regenerated sample configuration file with new messenger options using oslo-config-generatordoc/source/configuration.rst: Added documentation for messenger record type filtering, including a table mapping record types to extractors and example configurationsreleasenotes/notes/messenger-record-type-filtering-*.yaml: Added release notes documenting the new feature and upgrade notesType of change
How Has This Been Tested?
caso/tests/test_messenger.pycovering filtering logic, default configurations, and edge cases[messenger_*]sections withrecord_typesoptionChecklist:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.