Skip to content

Conversation

@YCShen1010
Copy link
Contributor

@YCShen1010 YCShen1010 commented May 7, 2025

What this PR does / why we need it:
Implement test cases for ODLM no olm controller:

  1. Setup test environment with fake client
  2. Create test fixtures for OperandRequest objects
  3. Test the main reconcile logic
  4. Test permission checking
  5. Test finalizer handling

Issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65886

Signed-off-by: YuChen <yuchen.shen@mail.utoronto.ca>
@ibm-ci-bot ibm-ci-bot requested review from Daniel-Fan and bitscuit May 7, 2025 21:36
@ibm-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qpdpQ
Copy link
Contributor

qpdpQ commented Nov 17, 2025

@YCShen1010 thank you for implement test cases no olm testcase, it looks good to me

@qpdpQ
Copy link
Contributor

qpdpQ commented Nov 17, 2025

/lgtm

@qpdpQ qpdpQ merged commit f9e2432 into IBM:master Nov 17, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants