Skip to content

Fix for passing initial push notification payload from connectionOpti… #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for passing initial push notification payload from connectionOpti… #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ios/RCTBridge+UIScene.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ @implementation RCTBridge (UIScene)
- (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate
connectionOptions:(UISceneConnectionOptions *)connectionOptions
{
if (connectionOptions.notificationResponse) {
NSDictionary<UIApplicationLaunchOptionsKey, id> *launchOptions = @{
UIApplicationLaunchOptionsRemoteNotificationKey: connectionOptions.notificationResponse.notification.request.content.userInfo,
};

return [self initWithDelegate:delegate launchOptions:launchOptions];
Copy link
Owner

@Gustash Gustash Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we returning early here? Shouldn't we be sending this information along with any other information in connectionOptions?

Or would that scenario never happen?

}

if (connectionOptions.userActivities.count < 1) {
return [self initWithDelegate:delegate launchOptions:@{}];
}
Expand Down