Fix Vello rendering bug with stroke alignment cropped by parent transformations #3329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
please review @Keavon |
Keavon
force-pushed
the
fix/vello-stroke-alignment-cropping
branch
from
f7ef31a to
b11ad25
Compare
Keavon
changed the title
Member
|
!build |
|
Member
|
@ashishmohapatra240 can you please comment in the original issue that you're submitting this fix, so GitHub allows me to assign it to you? |
Keavon
approved these changes
Nov 11, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3179
When
alignment_parent_transformis set, calculateelement_transformas the inverse composition:multiplied_transform * alignment_transform.inverse(). This ensures the mask is correctly positioned in the same coordinate space as the stroke.Graphite2.mp4