-
-
Notifications
You must be signed in to change notification settings - Fork 995
Provide shaders via artifact repo (prototype) #3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Provide shaders via artifact repo (prototype) #3250
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
7e9b2d5 to
c0bb106
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
With @TrueDoctor adding the automatic switches between the GPU and CPU variants, end users shouldn't need to use GPU nodes directly. I assume if GPU nodes aren't build, we just default to the CPU variants. So for a typical end-user who doesn't build shaders, everything should still work as expected, at most they get a failing CI later cause the shaders don't compile. Now you'd have to make sure a regular contributor changing a shader node uses the CPU implementation and not the GPU implementation from cached master, without their changes. Or is this only for building desktop on some platforms? Couldn't we have a github job / nix thing to build the shaders and pass the artifacts to the next step, entering whatever build env doesn't support rust-gpu's separate toolchain? |
Yes and also only a PoC.
This essentially dose that, but nixpkgs is not part of our ci thus we need to host the artifacts needed for that build statically somewhere (probably a bucket in the end). |
c0bb106 to
36a0795
Compare
36a0795 to
2112e97
Compare
2112e97 to
4aff0c6
Compare
4aff0c6 to
7963768
Compare
7963768 to
1a973e7
Compare
Build and upload graphene raster nodes shaders in a separate artifacts repo.
Needed for build environments were we can't use the rust gpu pinned rust nightly toolchain in. I'm most concerned about nixpkgs. Can also be used to significantly speed up builds (desktop on all platforms).
Currently running on every push we can think about doing this only on master, but runtime is <3m so should be fine for now.
Currently using my own repo, should preoby live in a GraphiteInfra org.
https://github.com/timon-schelling/graphite-artifacts
I have set the following for the repo.
vars:
ARTIFACTS_REPO_OWNER = timon-schelling
ARTIFACTS_REPO_NAME = graphite-artifacts
ARTIFACTS_REPO_BRANCH = main
secrets:
ARTIFACTS_REPO_TOKEN = github_pat_*** (access token limited to write on that one repo)
Also includes: desktop enable shader nodes