Skip to content

fix: Fix failing checks #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: Fix failing checks #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
244f651
fix: Add setuptools as an explicit test dependency
nifflets Dec 28, 2024
1ab1958
Remove python 3.7 and 3.8 from tests
nifflets Dec 28, 2024
19e3064
Add py37 and py38 support back in
nifflets Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,16 @@ permissions: read-all

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
python: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
python: ['3.9', '3.10', '3.11', '3.12']
Copy link

@liuyunnnn liuyunnnn Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we absolutely sure we should remove these two versions? Seems to me that we still support 3.7 and 3.8 according to https://screenshot.googleplex.com/4TSpCmAE3z63Axt https://screenshot.googleplex.com/4oTVpkPBHbbBw8b

platform: [ubuntu-latest]
include:
- platform: ubuntu-22.04
python: '3.8'
- platform: ubuntu-22.04
python: '3.7'
runs-on: ${{ matrix.platform }}
steps:
- name: Harden Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,21 @@ jobs:
python: '3.8'
- platform: macos-latest
python: '3.7'
- platform: ubuntu-latest
python: '3.8'
- platform: ubuntu-latest
python: '3.7'
include:
- platform: macos-latest
python: '3.9'
- platform: macos-13
python: '3.8'
- platform: macos-13
python: '3.7'
- platform: ubuntu-22.04
python: '3.8'
- platform: ubuntu-22.04
python: '3.7'
runs-on: ${{ matrix.platform }}
steps:
- name: Harden Runner
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ deps =
twine
isort
mypy
setuptools
commands =
black --check src tests setup.py conftest.py --exclude tests/test_functions/background_load_error/main.py
isort -c src tests setup.py conftest.py
Expand Down
Loading