Fix pushing Issues VC when user taps on username in referenced issues (#2766)

* mark issue title & number with MarkdownAttribute.issue, set IssueDetailsModel as value

* delegate MarkdownStyledTextView taps to IssueReferencedSectionController

* don't mark issue title & number with markdown attribute, allow issues to go through didSelectItem flow

* swap switch for if/else

* use the result of handle(attribute:) to set shouldShowIssueOnItemSelection

Author: Natalia Harateh

Classes/Issues/Referenced/IssueReferencedSectionController.swift

@@ -9,7 +9,7 @@
 import Foundation
 import IGListKit
 
-final class IssueReferencedSectionController: ListGenericSectionController<IssueReferencedModel> {
+final class IssueReferencedSectionController: ListGenericSectionController<IssueReferencedModel>, MarkdownStyledTextViewDelegate {
 
     private let client: GithubClient
 
@@ -29,14 +29,29 @@ final class IssueReferencedSectionController: ListGenericSectionController<Issue
         let object = self.object
             else { fatalError("Missing context, model, or cell wrong type") }
         cell.configure(object)
-        cell.delegate = viewController
+        cell.delegate = self
         return cell
     }
 
+    private var shouldShowIssueOnItemSelection: Bool = true
+
     override func didSelectItem(at index: Int) {
+        guard shouldShowIssueOnItemSelection else {
+            shouldShowIssueOnItemSelection = true
+            return
+        }
         guard let object = self.object else { return }
         let model = IssueDetailsModel(owner: object.owner, repo: object.repo, number: object.number)
         viewController?.route_push(to: IssuesViewController(client: client, model: model))
     }
 
+    // MARK: MarkdownStyledTextViewDelegate
+
+    func didTap(cell: MarkdownStyledTextView, attribute: DetectedMarkdownAttribute) {
+        guard let viewController = viewController else {
+            return
+        }
+        shouldShowIssueOnItemSelection = !viewController.handle(attribute: attribute)
+    }
+
 }