Enable individual bookmark deletes (#2741)

* update bookmarks to SwipeSelectableCell

* add ability to delete

* undo return separation

* remove using section

* move protocol to bookmark vc

* add markers

Author: rluftw

Classes/Bookmark/BookmarkCell.swift

@@ -10,7 +10,7 @@ import UIKit
 import SnapKit
 import StyledTextKit
 
-final class BookmarkCell: SelectableCell {
+final class BookmarkCell: SwipeSelectableCell {
 
     static let titleInset = UIEdgeInsets(
         top: Styles.Sizes.rowSpacing,

Classes/Bookmark/BookmarkIssueSectionController.swift

@@ -9,8 +9,15 @@
 import Foundation
 import IGListKit
 import GitHawkRoutes
+import SwipeCellKit
 
-final class BookmarkIssueSectionController: ListSwiftSectionController<BookmarkIssueViewModel> {
+final class BookmarkIssueSectionController: ListSwiftSectionController<BookmarkIssueViewModel>, SwipeCollectionViewCellDelegate {
+
+    private weak var delegate: BookmarkSectionControllerDelegate?
+
+    init(delegate: BookmarkSectionControllerDelegate?) {
+        self.delegate = delegate
+    }
 
     override func createBinders(from value: BookmarkIssueViewModel) -> [ListBinder] {
         return [
@@ -23,6 +30,7 @@ final class BookmarkIssueSectionController: ListSwiftSectionController<BookmarkI
                     )
             }, configure: {
                 $0.configure(with: $1.value)
+                $0.delegate = self
             }, didSelect: { [weak self] context in
                 self?.viewController?.route(IssueRoute(
                     owner: context.value.repo.owner,
@@ -33,4 +41,15 @@ final class BookmarkIssueSectionController: ListSwiftSectionController<BookmarkI
         ]
     }
 
+    // MARK: SwipeCollectionViewCellDelegate
+
+    func collectionView(_ collectionView: UICollectionView, editActionsForRowAt indexPath: IndexPath, for orientation: SwipeActionsOrientation) -> [SwipeAction]? {
+        guard orientation == .right else { return nil }
+
+        let action = DeleteSwipeAction { _, indexPath in
+            self.delegate?.didSwipeToDelete(at: indexPath)
+        }
+
+        return [action]
+    }
 }

Classes/Bookmark/BookmarkRepoCell.swift

@@ -9,7 +9,7 @@
 import UIKit
 import SnapKit
 
-final class BookmarkRepoCell: SelectableCell {
+final class BookmarkRepoCell: SwipeSelectableCell {
 
     private let imageView = UIImageView(image: UIImage(named: "repo").withRenderingMode(.alwaysTemplate))
     private let label = UILabel()

Classes/Bookmark/BookmarkRepoSectionController.swift

@@ -9,8 +9,15 @@
 import Foundation
 import IGListKit
 import GitHawkRoutes
+import SwipeCellKit
 
-final class BookmarkRepoSectionController: ListSwiftSectionController<RepositoryDetails> {
+final class BookmarkRepoSectionController: ListSwiftSectionController<RepositoryDetails>, SwipeCollectionViewCellDelegate {
+
+    private weak var delegate: BookmarkSectionControllerDelegate?
+
+    init(delegate: BookmarkSectionControllerDelegate?) {
+        self.delegate = delegate
+    }
 
     override func createBinders(from value: RepositoryDetails) -> [ListBinder] {
         return [
@@ -21,6 +28,7 @@ final class BookmarkRepoSectionController: ListSwiftSectionController<Repository
                     return $0.collection.cellSize(with: Styles.Sizes.tableCellHeightLarge)
             }, configure: {
                 $0.configure(owner: $1.value.owner, name: $1.value.name)
+                $0.delegate = self
             }, didSelect: { [weak self] context in
                 self?.viewController?.route(RepoRoute(
                     owner: context.value.owner,
@@ -31,4 +39,15 @@ final class BookmarkRepoSectionController: ListSwiftSectionController<Repository
         ]
     }
 
+    // MARK: SwipeCollectionViewCellDelegate
+
+    func collectionView(_ collectionView: UICollectionView, editActionsForRowAt indexPath: IndexPath, for orientation: SwipeActionsOrientation) -> [SwipeAction]? {
+        guard orientation == .right else { return nil }
+
+        let action = DeleteSwipeAction { _, _ in
+            self.delegate?.didSwipeToDelete(at: indexPath)
+        }
+
+        return [action]
+    }
 }

Classes/Bookmark/BookmarkViewController.swift

@@ -10,6 +10,10 @@ import Foundation
 import IGListKit
 import Squawk
 
+protocol BookmarkSectionControllerDelegate: AnyObject {
+    func didSwipeToDelete(at indexPath: IndexPath)
+}
+
 protocol BookmarkViewControllerClient {
     func fetch(graphQLIDs: [String], completion: @escaping (Result<[BookmarkModelType]>) -> Void)
 }
@@ -23,7 +27,8 @@ final class BookmarkViewController: BaseListViewController<String>,
 BaseListViewControllerDataSource,
 BaseListViewControllerEmptyDataSource,
 BookmarkIDCloudStoreListener,
-BookmarkHeaderSectionControllerDelegate {
+BookmarkHeaderSectionControllerDelegate,
+BookmarkSectionControllerDelegate {
 
     typealias Client = BookmarkViewControllerClient & BookmarkCloudMigratorClient
 
@@ -150,11 +155,11 @@ BookmarkHeaderSectionControllerDelegate {
             switch $0 {
             case .issue(let model):
                 return ListSwiftPair.pair(model, {
-                    BookmarkIssueSectionController()
+                    BookmarkIssueSectionController(delegate: self)
                 })
             case .repo(let model):
                 return ListSwiftPair.pair(model, {
-                    BookmarkRepoSectionController()
+                    BookmarkRepoSectionController(delegate: self)
                 })
             }
         }
@@ -194,4 +199,10 @@ BookmarkHeaderSectionControllerDelegate {
         cloudStore.clear()
     }
 
+    // MARK: BookmarkSectionControllerDelegate
+
+    func didSwipeToDelete(at indexPath: IndexPath) {
+        let graphQLID = cloudStore.ids[indexPath.section-1]
+        cloudStore.remove(graphQLID: graphQLID)
+    }
 }