Add insecure option, deprecate allowSelfSigned #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agateau-gg
force-pushed
the
agateau/insecure
branch
from
675a73d to
703f104
Compare
sevbch
reviewed
Oct 29, 2025
Contributor
sevbch
left a comment
sevbch
left a comment
There was a problem hiding this comment.
LGTM, just a couple comments
Also, adding @GabrielCousin as reviewer as he's a typescript expert
6d7a
requested changes
Oct 29, 2025
Contributor
6d7a
left a comment
6d7a
left a comment
There was a problem hiding this comment.
Just some orthography suggestions.
sevbch
approved these changes
Oct 31, 2025
6d7a
approved these changes
Oct 31, 2025
GabrielCousin
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ggshield 1.44 introduced the
--insecureoption to replace the ambiguous--allow-self-signed. This PR makes similar changes to the VSCode extension.What has been done
insecure.allowSelfSignedsetting as deprecated.--insecureinstead of--allow-self-signed.If
allowSelfSignedis set then it shows up like this in the UI:When it's unset, it does not appear at all in the UI:
PR check list