Skip to content

Conversation

@Gaardsholt
Copy link
Owner

@Gaardsholt Gaardsholt commented Oct 22, 2025

Potential fix for #16

@Gaardsholt Gaardsholt marked this pull request as ready for review October 23, 2025 07:07
@Wikiwix
Copy link

Wikiwix commented Oct 23, 2025

The linting worked in my example, but the fixing (still) fails with this error:

Failed to check ruleset; failed to apply fixes by "terraform_lists_trailing_comma" rule: path/to/file.tf:148,1-1: Unterminated template string; No closing marker was found for the string.

Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
@Gaardsholt
Copy link
Owner Author

The linting worked in my example, but the fixing (still) fails with this error:

Failed to check ruleset; failed to apply fixes by "terraform_lists_trailing_comma" rule: path/to/file.tf:148,1-1: Unterminated template string; No closing marker was found for the string.

Shouldn't have trusted the AI - I have made some changes and in my testing it seems to work :)
Can you test it again?

@Wikiwix
Copy link

Wikiwix commented Oct 24, 2025

Appears to be working for my real world example as well :)

@Gaardsholt
Copy link
Owner Author

Great !
Let's get it released then! :)

@Gaardsholt Gaardsholt merged commit 76d394e into main Oct 24, 2025
3 checks passed
@Gaardsholt Gaardsholt deleted the supporting-heredocs branch October 24, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants