Working

Author: robotdan

src/main/java/io/fusionauth/http/io/ChunkedInputStream.java

@@ -162,7 +162,7 @@ private int processChunk(byte[] destination, int offset, int length) throws IOEx
           continue;
         }
 
-        // TODO : If we wanted to handle more than one chunk at a time, I think we would potentially continue here
+        // TODO : Daniel : If we wanted to handle more than one chunk at a time, I think we would potentially continue here
         //        and see if we can get more than one chunk completed before copying back to the destination.
         //        Discuss with Brian.
         //        Should we try this right now, or is this ok? Load testing with a small body,

src/main/java/io/fusionauth/http/server/internal/HTTPWorker.java

@@ -291,7 +291,6 @@ private void closeSocketOnError(HTTPResponse response, int status) {
       logger.debug(String.format("[%s] Could not close the HTTP response.", Thread.currentThread().threadId()), e);
     } finally {
       // It is plausible that calling response.close() could throw an exception. We must ensure we close the socket.
-      // TODO : Daniel : Review : Can I write a test to force this condition?
       closeSocketOnly(CloseSocketReason.Unexpected);
     }
   }

src/test/java/io/fusionauth/http/CoreTest.java

@@ -116,7 +116,7 @@ public void badPreambleButReset() throws Exception {
     try (var client = HttpClient.newHttpClient(); var ignore = makeServer("http", handler, instrumenter).start()) {
       // Invalid request, missing Host header
       // - This should cause the socket to be reset
-      // TODO : If we return a 400 since this is a client error and not a server error we are not currently resetting the request.
+      // TODO : Daniel : Review : If we return a 400 since this is a client error and not a server error we are not currently resetting the request.
       //        Do we need to?
       //        Discuss with Brian?
       sendBadRequest("""
@@ -749,7 +749,7 @@ public void serverTimeout() throws Exception {
       println("Closed");
     };
 
-    // TODO : Daniel Review : what are we trying to test here, this test isn't doing what we think.
+    // TODO : Daniel : Review : what are we trying to test here, this test isn't doing what we think.
     //        It seems we are writing to the server as a client, and the server is slow to write back.
     //        But this would be a client timeout and not a server timeout?
     //       Seems like we should use withProcessingTimeoutDuration instead of withInitialReadTimeout?