Working

Author: robotdan

src/main/java/io/fusionauth/http/io/PushbackInputStream.java

@@ -91,11 +91,6 @@ public int read() throws IOException {
     return b1[0] & 0xFF;
   }
 
-  @Override
-  public byte[] readAllBytes() throws IOException {
-    return super.readAllBytes();
-  }
-
   public void setDelegate(InputStream delegate) {
     this.delegate = delegate;
   }

src/main/java/io/fusionauth/http/server/HTTPServerConfiguration.java

@@ -450,8 +450,8 @@ public HTTPServerConfiguration withMaximumBytesToDrain(int maxBytesToDrain) {
    */
   @Override
   public HTTPServerConfiguration withMinimumReadThroughput(long bytesPerSecond) {
-    if (bytesPerSecond != -1 && bytesPerSecond < 1024) {
-      throw new IllegalArgumentException("The minimum bytes per second must be greater than 1024. This should probably be faster than a 28.8 baud modem!");
+    if (bytesPerSecond != -1 && bytesPerSecond < 512) {
+      throw new IllegalArgumentException("The minimum bytes per second must be greater than 512. Note that the theoretical maximum transmission speed of a 28.8k is 28,800 bits /second, or 3,600 bytes /second. Maybe consider requiring the read throughput to be faster than a 28.8k modem.");
     }
 
     this.minimumReadThroughput = bytesPerSecond;
@@ -462,8 +462,8 @@ public HTTPServerConfiguration withMinimumReadThroughput(long bytesPerSecond) {
    * {@inheritDoc}
    */
   public HTTPServerConfiguration withMinimumWriteThroughput(long bytesPerSecond) {
-    if (bytesPerSecond != -1 && bytesPerSecond < 1024) {
-      throw new IllegalArgumentException("The minimum bytes per second must be greater than 1024. This should probably be faster than a 28.8 baud modem!");
+    if (bytesPerSecond != -1 && bytesPerSecond < 512) {
+      throw new IllegalArgumentException("The minimum bytes per second must be greater than 512. Note that the theoretical maximum transmission speed of a 28.8k is 28,800 bits /second, or 3,600 bytes /second. Maybe consider requiring the write throughput to be faster than a 28.8k modem.");
     }
 
     this.minimumWriteThroughput = bytesPerSecond;

src/main/java/io/fusionauth/http/server/internal/HTTPServerThread.java

@@ -193,18 +193,8 @@ public void run() {
           ClientInfo client = iterator.next();
           Thread thread = client.thread();
           long threadId = thread.threadId();
-          boolean threadIsAlive = thread.isAlive();
-          var threadState = thread.getState();
-          if (threadState == Thread.State.TERMINATED) {
-            if (threadIsAlive) {
-              System.out.println("[" + threadId + "] is alive in state [" + threadState + "]");
-            }
-          } else if (!threadIsAlive) {
-            System.out.println("[" + threadId + "] is dead in state [" + threadState + "]");
-          }
-
-          if (!threadIsAlive) {
-            logger.debug("[{}] Remove dead client worker. Thread state [{}] Born [{}]. Died at age [{}] ms. Requests handled [{}].", threadId, threadState, client.getStartInstant(), client.getAge(), client.getHandledRequests());
+          if (!thread.isAlive()) {
+            logger.trace("[{}] Remove dead client worker. Born [{}]. Died at age [{}] ms. Requests handled [{}].", threadId, client.getStartInstant(), client.getAge(), client.getHandledRequests());
             iterator.remove();
             removedClientCount++;
             continue;