Working

Author: robotdan

src/test/java/io/fusionauth/http/CoreTest.java

@@ -740,7 +740,7 @@ public void serverTimeout() throws Exception {
     HTTPHandler handler = (req, res) -> {
       println("Handling ... (slowly)");
       // Note that if you comment out the sleep, the test should fail.
-      sleep(4_000L);
+      sleep(3_000L);
       res.setStatus(200);
       var body = "I'm slow but I'm good.".getBytes(StandardCharsets.UTF_8);
       res.setContentLength(body.length);
@@ -749,12 +749,17 @@ public void serverTimeout() throws Exception {
       println("Closed");
     };
 
-    // TODO : Daniel : Review : what are we trying to test here, this test isn't doing what we think.
-    //        It seems we are writing to the server as a client, and the server is slow to write back.
-    //        But this would be a client timeout and not a server timeout?
-    //       Seems like we should use withProcessingTimeoutDuration instead of withInitialReadTimeout?
     var instrumenter = new CountingInstrumenter();
-    try (var ignore = makeServer("http", handler, instrumenter).withProcessingTimeoutDuration(Duration.ofSeconds(1)).start(); Socket socket = new Socket("127.0.0.1", 4242)) {
+    try (var ignore = makeServer("http", handler, instrumenter)
+        // The processing timeout should be triggered due to how slow the server is to write back to the client.
+        // - Increase other timeouts to be certain we are testing the correct one.
+        .withProcessingTimeoutDuration(Duration.ofSeconds(1))
+        .withInitialReadTimeout(Duration.ofSeconds(30))
+        .withKeepAliveTimeoutDuration(Duration.ofSeconds(30))
+        .start();
+
+         // Open a socket to the server and begin writing.
+         Socket socket = new Socket("127.0.0.1", 4242)) {
       var out = socket.getOutputStream();
       // 1. Write a body to the server
       out.write("""