Skip to content

Conversation

@teymour
Copy link

@teymour teymour commented Mar 18, 2022

PHP8 corrections

@alquerci
Copy link
Contributor

alquerci commented Mar 18, 2022

Hello @teymour

That's a huge work here.

Can you base your work on #262 and #263 then execute tests ?

Copy link
Collaborator

@Tybaze Tybaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be carefull,

date and strftime do not share the same format.

You can change the default timeFormat, but it will break a lot of setup (because default Sf1 timeformat is missing year, it's common to change it)

I'll try to provide a fix

@Tybaze Tybaze mentioned this pull request Jun 10, 2022
@Tybaze
Copy link
Collaborator

Tybaze commented Nov 28, 2022

I think we can close this PR, everything has been included into the merged #266

Thank you very much @teymour your list of modifications was usefull 👍

@teymour
Copy link
Author

teymour commented Dec 6, 2022

Thank you very much @teymour your list of modifications was usefull +1

Thanks for your work ! This new version works on our projects on PHP 8.1 and 7.4. It's a great news !!

@teymour teymour closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants