Skip to content

Store barcode only when used #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Store barcode only when used #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions app/src/main/java/com/freshkeeper/service/product/ProductServiceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,11 @@ class ProductServiceImpl
else -> null
}

val cleanedBarcode = barcode?.takeIf { it.isNotBlank() }

val foodItem =
FoodItem(
barcode = barcode,
barcode = cleanedBarcode,
userId = user.id,
householdId = householdId,
name = productName,
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FoodItem object is created but never used after line 119 switches to using foodItemData. This creates unnecessary object instantiation and potential confusion about which data structure is actually persisted.

Copilot uses AI. Check for mistakes.
Expand All @@ -96,9 +98,25 @@ class ProductServiceImpl
picture = picture,
)
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FoodItem object is created but never used after line 119 switches to using foodItemData. This creates unnecessary object instantiation and potential confusion about which data structure is actually persisted.

Copilot uses AI. Check for mistakes.

val foodItemData =
mutableMapOf<String, Any>(
"userId" to user.id,
"name" to productName,
"expiryTimestamp" to expiryTimestamp,
"quantity" to quantity,
"unit" to unit,
"storageLocation" to storageLocation,
"category" to category,
"status" to FoodStatus.ACTIVE,
).apply {
cleanedBarcode?.let { this["barcode"] = it }
householdId?.let { this["householdId"] = it }
picture?.let { this["picture"] = it }
}
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded string keys in the map create a maintenance risk and potential for typos. Consider using property names from the FoodItem class or defining constants for these field names to ensure consistency.

Copilot uses AI. Check for mistakes.

firestore
.collection("foodItems")
.add(foodItem)
.add(foodItemData)
.addOnSuccessListener { documentReference ->
firestore
.collection("foodItems")
Expand Down