Fix dialog jump issue when result will not be execueted under empty query option #3862

Jack251970 · 2025-07-23T09:38:36Z

CHANGES

Originally, if users select empty query option, Flow will call Hide() before checking result SelectedResults.SelectedItem != null which can cause that SelectedResults.SelectedItem is cleared to null, leading to result check failure.

So I have applied these two changes to make it work and work better:

Remove SelectedResults.SelectedItem != null check since we have already gotten the selected item result
Remove DialogWindowHandle != nint.Zero check since we have already checked _isDialogJump flag
Do not hide search window when clicking results since right clicking to open will not hide search window, so we should keep their behaviour in consistence.

Follow on with #1018. Resolve #3861.

TEST

Work as expected. Tested by soul4kills

…uery option

gitstream-cm · 2025-07-23T09:39:34Z

🥷 Code experts: taooceros

Jack251970, taooceros have most 👩‍💻 activity in the files.
Jack251970, taooceros have most 🧠 knowledge in the files.

See details

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

	Jack251970	taooceros
JUL	16 additions & 1 deletions	344 additions & 65 deletions
JUN	25 additions & 13 deletions
MAY	529 additions & 316 deletions
APR	35 additions & 28 deletions
MAR	695 additions & 628 deletions
FEB	63 additions & 21 deletions

Knowledge based on git-blame:
Jack251970: 34%
taooceros: 17%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

coderabbitai · 2025-07-23T09:39:36Z

📝 Walkthrough

Walkthrough

The update changes the logic for handling the "Dialog Jump" left click in the OpenResultAsync method of MainViewModel.cs. It adds explicit type checking for DialogJumpResult, removes an unconditional window hide call, and introduces error logging for unexpected result types during dialog jumps.

Changes

File(s)	Summary of Changes
Flow.Launcher/ViewModel/MainViewModel.cs	Refactored dialog jump handling in `OpenResultAsync`: added type check for `DialogJumpResult`, removed unconditional `Hide()` call, and added error logging for unexpected result types.

Estimated code review effort

1 (~2 minutes)

Suggested reviewers

jjw24

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1da7e1e and 20f6a74.

📒 Files selected for processing (1)

Flow.Launcher/ViewModel/MainViewModel.cs (1 hunks)

🧠 Learnings (2)

📓 Common learnings

Learnt from: Yusyuriv
PR: Flow-Launcher/Flow.Launcher#3057
File: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs:0-0
Timestamp: 2024-11-03T07:40:11.014Z
Learning: In Flow Launcher, when using Windows Forms dialogs (e.g., in `JsonRPCPluginSettings.cs`), path validation is enabled by default in `OpenFileDialog` and `FolderBrowserDialog`, preventing users from selecting invalid paths, but it's possible to opt out of this validation on individual dialogs.

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3854
File: Flow.Launcher.Core/Plugin/PluginManager.cs:280-292
Timestamp: 2025-07-21T09:19:19.012Z
Learning: In Flow Launcher's PluginManager.cs, the post-initialization operations (RegisterResultsUpdatedEvent, UpdatePluginMetadataTranslation, RegisterPluginActionKeywords, DialogJump.InitializeDialogJumpPlugin, and AddPluginToLists) are designed to be exception-safe and do not require additional try-catch error handling according to the maintainer Jack251970.

Learnt from: jjw24
PR: Flow-Launcher/Flow.Launcher#2887
File: .cm/gitstream.cm:20-20
Timestamp: 2024-08-14T13:42:20.540Z
Learning: Ensure that search queries for GitHub PRs correctly match the available milestones and labels in the repository to avoid empty results.

Learnt from: jjw24
PR: Flow-Launcher/Flow.Launcher#2887
File: .cm/gitstream.cm:20-20
Timestamp: 2024-10-08T15:52:58.573Z
Learning: Ensure that search queries for GitHub PRs correctly match the available milestones and labels in the repository to avoid empty results.

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.

Flow.Launcher/ViewModel/MainViewModel.cs (8)

Learnt from: Yusyuriv
PR: #3057
File: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs:0-0
Timestamp: 2024-11-03T07:40:11.014Z
Learning: In Flow Launcher, when using Windows Forms dialogs (e.g., in JsonRPCPluginSettings.cs), path validation is enabled by default in OpenFileDialog and FolderBrowserDialog, preventing users from selecting invalid paths, but it's possible to opt out of this validation on individual dialogs.

Learnt from: Jack251970
PR: #3672
File: Flow.Launcher/MainWindow.xaml.cs:244-247
Timestamp: 2025-06-08T14:12:21.348Z
Learning: In Flow.Launcher, App.NotifyIcon is created before MainWindow creation, so null checks for App.NotifyIcon are not necessary when accessing it from MainWindow code.

Learnt from: Jack251970
PR: #3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.

Learnt from: Jack251970
PR: #3854
File: Flow.Launcher.Core/Plugin/PluginManager.cs:280-292
Timestamp: 2025-07-21T09:19:19.012Z
Learning: In Flow Launcher's PluginManager.cs, the post-initialization operations (RegisterResultsUpdatedEvent, UpdatePluginMetadataTranslation, RegisterPluginActionKeywords, DialogJump.InitializeDialogJumpPlugin, and AddPluginToLists) are designed to be exception-safe and do not require additional try-catch error handling according to the maintainer Jack251970.

Learnt from: Jack251970
PR: #3854
File: Flow.Launcher/App.xaml.cs:246-262
Timestamp: 2025-07-21T09:19:49.684Z
Learning: In Flow Launcher's App.xaml.cs, the asynchronous plugin initialization task (containing AbstractPluginEnvironment.PreStartPluginExecutablePathUpdate, PluginManager.LoadPlugins, PluginManager.InitializePluginsAsync, and AutoPluginUpdates) does not require additional try-catch error handling according to maintainer Jack251970, as these operations are designed to handle exceptions internally.

Learnt from: Jack251970
PR: #3791
File: Flow.Launcher.Core/Plugin/PluginManager.cs:293-295
Timestamp: 2025-07-01T05:46:13.251Z
Learning: In Flow.Launcher.Core/Plugin/PluginManager.cs, when checking if a plugin is modified within the PluginManager class itself, prefer using the internal static PluginModified(string id) method directly rather than going through API.PluginModified() for better performance and architectural design.

Learnt from: Jack251970
PR: #3672
File: Flow.Launcher/MainWindow.xaml.cs:318-318
Timestamp: 2025-06-08T14:12:12.842Z
Learning: In Flow.Launcher, the App.NotifyIcon static property is initialized in the App class before MainWindow creation, so null checks are not needed when accessing App.NotifyIcon in MainWindow lifecycle methods.

Learnt from: Yusyuriv
PR: #3057
File: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs:0-0
Timestamp: 2024-11-03T07:34:24.926Z
Learning: In Windows Forms dialogs, Windows handles invalid paths and prevents the user from clicking "Ok" if the path is incorrect, so additional path validation is unnecessary.

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: Yusyuriv
PR: Flow-Launcher/Flow.Launcher#3057
File: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs:0-0
Timestamp: 2024-11-03T07:40:11.014Z
Learning: In Flow Launcher, when using Windows Forms dialogs (e.g., in `JsonRPCPluginSettings.cs`), path validation is enabled by default in `OpenFileDialog` and `FolderBrowserDialog`, preventing users from selecting invalid paths, but it's possible to opt out of this validation on individual dialogs.

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3854
File: Flow.Launcher.Core/Plugin/PluginManager.cs:280-292
Timestamp: 2025-07-21T09:19:19.012Z
Learning: In Flow Launcher's PluginManager.cs, the post-initialization operations (RegisterResultsUpdatedEvent, UpdatePluginMetadataTranslation, RegisterPluginActionKeywords, DialogJump.InitializeDialogJumpPlugin, and AddPluginToLists) are designed to be exception-safe and do not require additional try-catch error handling according to the maintainer Jack251970.

Learnt from: jjw24
PR: Flow-Launcher/Flow.Launcher#2887
File: .cm/gitstream.cm:20-20
Timestamp: 2024-08-14T13:42:20.540Z
Learning: Ensure that search queries for GitHub PRs correctly match the available milestones and labels in the repository to avoid empty results.

Learnt from: jjw24
PR: Flow-Launcher/Flow.Launcher#2887
File: .cm/gitstream.cm:20-20
Timestamp: 2024-10-08T15:52:58.573Z
Learning: Ensure that search queries for GitHub PRs correctly match the available milestones and labels in the repository to avoid empty results.

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.