OPS-2581 Correcting dup subnets logic #6
Conversation
| - "{{ aws_vpc_rt_subnet_by_cidr }}" | ||
| - "{{ aws_vpc_rt_subnet_by_filter }}" | ||
| - "{{ aws_vpc_rt_subnet_by_id }}" | ||
| when: not ([item] in aws_vpc_route_table_subnets) |
There was a problem hiding this comment.
I'd say we should assert here and error out in order to make the user aware of the fact that two duplicate subnets have been found.
There was a problem hiding this comment.
Is that really an error? Could we not in theory have two subnets with duplicated facts but in different fields? If it is, then I would agree, but it sounds to me that it might not be in all cases.
There was a problem hiding this comment.
In particular, maybe two subnets with the same tags?
There was a problem hiding this comment.
It is search by filter. So you could for example only specify tag:department=DevOps which would return a lot of subnets which all have this tag attached.
There was a problem hiding this comment.
Well, then the question is whether or not we would have some sort of logic to detect when filters are given which return too many subnets? Perhaps a ticket should be opened to deal with this later on? For now the change I made will keep duplicate subnets from being added to the route table subnet list.
Modified code to add a when statement that will not add a subnet to the returned list if it is already there.