Skip to content

IsUnicode support in StringLiteralQueryType methods #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

IsUnicode support in StringLiteralQueryType methods #1208

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc59db7
Add isUnicode parameter to StringLiteralQueryType function
gilsonjoanelo Sep 24, 2024
b2c7eb9
Update code to use ternary operator
gilsonjoanelo Sep 25, 2024
4dd2e5a
Change to string.empty
gilsonjoanelo Sep 26, 2024
7b69cd2
Merge branch 'FirebirdSQL:master' into master
gilsonjoanelo Sep 26, 2024
a7574a0
Merge branch 'FirebirdSQL:master' into master
gilsonjoanelo Jan 12, 2025
751080c
Merge branch 'FirebirdSQL:master' into master
gilsonjoanelo May 25, 2025
776a927
Correção do erro Implementation limit exceeded
gilsonjoanelo May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/FirebirdSql.EntityFrameworkCore.Firebird/Query/Internal/FbQuerySqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,18 @@ protected override Expression VisitSqlParameter(SqlParameterExpression sqlParame
Sql.Append(" AS ");
if (sqlParameterExpression.Type == typeof(string))
{
var isUnicode = FbTypeMappingSource.IsUnicode(sqlParameterExpression.TypeMapping);
Sql.Append(((IFbSqlGenerationHelper)Dependencies.SqlGenerationHelper).StringParameterQueryType(isUnicode));
var storeTypeNameBase = sqlParameterExpression.TypeMapping.StoreTypeNameBase;
var size = sqlParameterExpression.TypeMapping.Size;

if (storeTypeNameBase != null && size != null)
{
Sql.Append($"{storeTypeNameBase}({size})");
}
else
{
var isUnicode = FbTypeMappingSource.IsUnicode(sqlParameterExpression.TypeMapping);
Sql.Append(((IFbSqlGenerationHelper)Dependencies.SqlGenerationHelper).StringParameterQueryType(isUnicode));
}
}
else
{
Expand All @@ -191,9 +201,19 @@ protected override Expression VisitSqlConstant(SqlConstantExpression sqlConstant
base.VisitSqlConstant(sqlConstantExpression);
if (shouldExplicitStringLiteralTypes)
{
var isUnicode = FbTypeMappingSource.IsUnicode(sqlConstantExpression.TypeMapping);
Sql.Append(" AS ");
Sql.Append(((IFbSqlGenerationHelper)Dependencies.SqlGenerationHelper).StringLiteralQueryType(sqlConstantExpression.Value as string, isUnicode));
var storeTypeNameBase = sqlConstantExpression.TypeMapping.StoreTypeNameBase;
var size = sqlConstantExpression.TypeMapping.Size;

if (storeTypeNameBase != null && size != null)
{
Sql.Append($"{storeTypeNameBase}({size})");
}
else
{
var isUnicode = FbTypeMappingSource.IsUnicode(sqlConstantExpression.TypeMapping);
Sql.Append(" AS ");
Sql.Append(((IFbSqlGenerationHelper)Dependencies.SqlGenerationHelper).StringLiteralQueryType(sqlConstantExpression.Value as string, isUnicode));
}
Sql.Append(")");
}
return sqlConstantExpression;
Expand Down
Loading