Skip to content

Fei gha changesets #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fei gha changesets #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1fc0d95
make something great
Feiyang1 Jun 25, 2020
af017ee
show branches
Feiyang1 Jun 25, 2020
cc7906c
use v2
Feiyang1 Jun 25, 2020
c99efd6
set depth to 0
Feiyang1 Jun 25, 2020
3e5d06e
compare with origin master
Feiyang1 Jun 25, 2020
4e30070
test
Feiyang1 Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/changesets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@master
uses: actions/checkout@v2
with:
## fetch all history for all branches and tags, so we can compare with master
fetch-depth: 0

- name: Show branches
run: git branch

- name: Setup Node.js 12.x
uses: actions/setup-node@master
Expand All @@ -23,6 +26,6 @@ jobs:

- name: Install Dependencies
run: yarn

- name: Check if any Changeset file exists
run: yarn changeset status --since=master
run: yarn changeset status --since=origin/master
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@master
uses: actions/checkout@v2
with:
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion packages/app/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { isNode, isBrowser } from '@firebase/util';
import { logger } from './src/logger';
import { registerCoreComponents } from './src/registerCoreComponents';

// Firebase Lite detection test
// Firebase Lite detection test make it great
// eslint-disable-next-line @typescript-eslint/no-explicit-any
if (isBrowser() && (self as any).firebase !== undefined) {
logger.warn(`
Expand Down